Skip to content

feat(@schematics/angular): allow application migration to use new build package in projects where possible #27520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 23, 2024

When using the optional application build system migration, the newly
introduced @angular/build package which contains only the new build
system and no Webpack-related dependencies will be directly used when
possible. The migration will check for usage of any other builders from
the @angular-devkit/build-angular package. if none are present in the
angular.json file (excluding dev-server and extract-i18n), the
@angular/build package will be added as a dependency and used in the
angular.json file. The @angular-devkit/build-angular package will
then be removed as a dependency. Project usage of karma and/or protractor
will be the most common reasons this part of the migration will not be
performed.

Also includes a fix to the migration to no longer remove the now support deployUrl option.

…lication builder

The `deployUrl` option is now supported with the new build system
when using the `application` builder. The migration schematic
no longer needs to remove the option if present.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 23, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 23, 2024
@clydin clydin force-pushed the application/cleanup-2 branch from 5582122 to 95ce022 Compare April 23, 2024 20:28
…ld package in projects where possible

When using the optional application build system migration, the newly
introduced `@angular/build` package which contains only the new build
system and no Webpack-related dependencies will be directly used when
possible. The migration will check for usage of any other builders from
the `@angular-devkit/build-angular` package. if none are present in the
`angular.json` file (excluding `dev-server` and `extract-i18n`), the
`@angular/build` package will be added as a dependency and used in the
`angular.json` file. The `@angular-devkit/build-angular` package will
then be removed as a dependency. Project usage of karma and/or protractor
will be the most common reasons this part of the migration will not be
performed.
@clydin clydin force-pushed the application/cleanup-2 branch from 95ce022 to 094e85c Compare April 23, 2024 22:03
@clydin clydin marked this pull request as ready for review April 23, 2024 22:35
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 24, 2024
@clydin clydin merged commit b2ac5fa into angular:main Apr 24, 2024
34 checks passed
@clydin clydin deleted the application/cleanup-2 branch April 24, 2024 11:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants