Skip to content

refactor(@angular/build): move postcss stylesheet processor to an optional peer dependency #27561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 29, 2024

The Postcss stylesheet processor is now an optional peer dependency of the newly introduced @angular/build build system package. This change removes the need for the package to have a direct dependency on the postcss package and allows some version customization of the optional postcss package if needed. Postcss plugins (including Tailwind) are still fully supported but usage will now require installing the postcss package within the Angular workspace. An error with instructions to install the package will be generated during a build if the package is not present. This change only affects direct usage of the new @angular/build package. The @angular-devkit/build-angular package which is currently used for all existing projects will continue to contain and directly depend on the postcss package.

No changes are required for existing applications.

…ional peer dependency

The Postcss stylesheet processor is now an optional peer dependency of the
newly introduced `@angular/build` build system package. This change removes
the need for the package to have a direct dependency on the `postcss` package
and allows some version customization of the optional `postcss` package if needed.
Postcss plugins (including Tailwind) are still fully supported but usage will now require installing
the `postcss` package within the Angular workspace. An error with instructions to
install the package will be generated during a build if the package is not present.
This change only affects direct usage of the new `@angular/build` package.
The `@angular-devkit/build-angular` package which is currently used for all existing
projects will continue to contain and directly depend on the `postcss` package.

No changes are required for existing applications.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Apr 29, 2024
@clydin clydin marked this pull request as ready for review April 29, 2024 21:42
@clydin clydin requested a review from alan-agius4 April 29, 2024 22:45
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 29, 2024
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we’d also need to add this as direct dependency when running the application builder migration

@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2024
@clydin clydin merged commit 6b5c51a into angular:main Apr 30, 2024
36 checks passed
@clydin clydin deleted the application/optional-postcss branch April 30, 2024 14:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants