Skip to content

fix(@schematics/angular): add postcss dependency in application migration if needed #27566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 30, 2024

The application migration schematic will now attempt to detect the usage of custom postcss plugins within a workspace and install the postcss dependency if required. This will only occur if the migration analysis allows for the conversion to use the @angular/build package instead of the @angular-devkit/build-angular package. Custom postcss configurations will be detected within the same locations as the build system itself which includes the workspace root and any project root for the postcss.config.json and .postcssrc.json files.

…tion if needed

The application migration schematic will now attempt to detect the usage
of custom postcss plugins within a workspace and install the `postcss` dependency
if required. This will only occur if the migration analysis allows for
the conversion to use the `@angular/build` package instead of the
`@angular-devkit/build-angular` package. Custom postcss configurations will
be detected within the same locations as the build system itself which includes
the workspace root and any project root for the `postcss.config.json` and
`.postcssrc.json` files.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Apr 30, 2024
@clydin clydin requested a review from alan-agius4 April 30, 2024 20:02
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 30, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 2, 2024
@clydin clydin merged commit 511d876 into angular:main May 2, 2024
35 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants