Skip to content

ci: add flag for preventing NpmPackageExtract from executing on RBE #29269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

josephperrott
Copy link
Member

No description provided.

Prevent NpmPackageExtract from running on RBE and overwhelming our quota
@josephperrott josephperrott added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project labels Jan 7, 2025
@josephperrott josephperrott requested a review from clydin January 7, 2025 18:15
@jkrems jkrems merged commit 4000959 into angular:main Jan 7, 2025
33 checks passed
@jkrems
Copy link
Contributor

jkrems commented Jan 7, 2025

The changes were merged into the following branches: main, 19.0.x

@josephperrott josephperrott deleted the trying-a-flag branch January 7, 2025 20:39
@jkrems
Copy link
Contributor

jkrems commented Jan 7, 2025

Saw some CI errors like this:

ERROR: /home/runner/work/angular-cli/angular-cli/packages/angular/build/BUILD.bazel:220:8:
Jq packages/angular/build/substituted/package.json failed:
(Exit 34): RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Queries' and limit 'Queries per minute per region'
of service 'remotebuildexecution.googleapis.com' for consumer 'project_number:823469418460'.

Could that be related?

@josephperrott
Copy link
Member Author

This change was an attempt to prevent us from hitting that limit, which it looks like we are still hitting. DevInfra is continuing to work on sorting out a solution long term.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants