Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Document default successCallback, errorCallback, notfiyCallback for promise.then(...) #8562

Closed
fiveop opened this issue Aug 11, 2014 · 1 comment
Closed

Document default successCallback, errorCallback, notfiyCallback for promise.then(...) #8562

fiveop opened this issue Aug 11, 2014 · 1 comment
Labels
type: docs
Milestone
Backlog - won't fix

Comments

@fiveop
Copy link

fiveop commented Aug 11, 2014

The documentation for the then method of promises constructed using the $q service does not describe the behaviour of the default callbacks.

After I figure out what the defaults are, I will draft a patch.
@btford
Copy link
Contributor

btford commented Aug 19, 2014

Perhaps the docs for Angular's promises could be clearer, but I don't think "default callbacks" clarifies. I think it might be better to note that the error and notification callbacks are optional in .then.

@btford btford added this to the Backlog milestone Aug 19, 2014
@wesleycho wesleycho mentioned this issue Jun 11, 2016
Merged
Narretz pushed a commit that referenced this issue Jun 15, 2016
@wesleycho @Narretz
docs($q): add note about optional arguments for promise.then()
36b38e1 
- Add note about optional arguments in the promise.then api

Closes #8562
PR (#14754)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
Backlog - won't fix
Development

No branches or pull requests
2 participants
@fiveop @btford