Skip to content

fix(material/menu): do not auto-focus when hover opens menu #31257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

adolgachev
Copy link
Contributor

@adolgachev adolgachev commented May 29, 2025

Currently, when a menu item is hovered over, it will automatically open the sub-menu and also focus the first item within the sub-menu.

When VoiceOver is enabled, the focus will then fire another hover event, and then the next sub-menu will open and so on. This prevents the user from being to hover over any other menu item.

Even without VoiceOver enabled, it is a bit confusing to the user that just hovering over each menu item will then shift focus to items in the sub-menu. Opening the menu makes sense, but the force of focus for hover is less usable.

@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase action: global presubmit The PR is in need of a google3 global presubmit requires: TGP This PR requires a passing TGP before merging is allowed labels May 29, 2025
Copy link

github-actions bot commented May 29, 2025

Deployed dev-app for 5c4da31 to: https://ng-dev-previews-comp--pr-angular-components-31257-dev-pf8wcsft.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev marked this pull request as ready for review May 29, 2025 23:07
@adolgachev adolgachev requested a review from a team as a code owner May 29, 2025 23:07
@adolgachev adolgachev requested review from mmalerba, ok7sai and wagnermaciel and removed request for a team and ok7sai May 29, 2025 23:07
@adolgachev adolgachev added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: global presubmit The PR is in need of a google3 global presubmit labels May 29, 2025
@adolgachev adolgachev removed the request for review from wagnermaciel May 30, 2025 18:33
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 30, 2025
@adolgachev adolgachev merged commit a62164d into angular:main May 30, 2025
23 of 25 checks passed
@adolgachev adolgachev deleted the menu branch May 30, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/menu dev-app preview When applied, previews of the dev-app are deployed to Firebase requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants