Skip to content

build: update to marked v16 and resolve breakages #31471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 1, 2025

Updates the repo to the latest version of marked and resolves some breaking changes that required us to switch some files to ESM. As a result, I had to disable syntax highlighting for type aliases and constants in the API docs, because it would've required us to rework the dgeni setup as well.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 1, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jul 1, 2025
@crisbeto crisbeto requested a review from devversion July 1, 2025 07:18
@crisbeto crisbeto marked this pull request as ready for review July 1, 2025 07:18
@crisbeto crisbeto requested review from a team as code owners July 1, 2025 07:18
@crisbeto crisbeto requested review from adolgachev and ok7sai and removed request for a team July 1, 2025 07:18
@crisbeto crisbeto added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Jul 1, 2025
crisbeto added 2 commits July 1, 2025 10:57
Updates the repo to the latest version of `marked` and resolves some breaking changes that required us to switch some files to ESM. As a result, I had to disable syntax highlighting for type aliases and constants in the API docs, because it would've required us to rework the dgeni setup as well.
Fixes that the tests for the Markdown renderer weren't compiling after the recent changes. I've also reworked them to make them closer to how they work inside of our scripts.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 1, 2025
@crisbeto crisbeto removed request for adolgachev and ok7sai July 1, 2025 09:09
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 1, 2025
@crisbeto crisbeto merged commit 8860e65 into angular:main Jul 1, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: preserve commits When the PR is merged, a rebase and merge should be performed target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants