Make tooltip static when selected #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshjms <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR aims to keep the tooltip in a fixed position when an element is selected.
Key changes include:
- Adding an early return in the mouse move handler to skip repositioning when an element is selected.
- Updating the display and positioning of the tooltip upon selection.
- Adjusting the tooltip and reset logic on mouse out and background click.
Comments suppressed due to low confidence (1)
visualization/index.js:784
- The 'event' variable is used here without being passed to the function; consider ensuring that the event is either passed as a parameter or otherwise defined in this context.
tooltip.style.left = event.pageX + 20 + 'px'
|
Great work @joshjms! but I don't know anything about JS so I cannot review :P |
|
It's ok, I'm also not good with JS, I hope @anishathalye can help review 😂 |
|
Hi @anishathalye , really sorry to ping you if you're busy. If I may know, is there anything else I can do to improve this? Thanks! |
|
Thank you! Fixed a small bug in 9c675ba. Released as v1.0.3. |
|
Ooh thanks a lott!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image isn't very clear to show but my cursor is not hovering at the time of that screenshot 😂
Please take a look 😄
/cc @anishathalye
Reference: #29