Use git rev-parse --show-toplevel for the root dir. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so that the test scripts do not necessarily have to be run from the top level of the repository.
foxish
reviewed
Jan 9, 2018
e2e/runner.sh
Outdated
| cd $root/integration-test | ||
| $root/spark/build/mvn clean -Ddownload.plugin.skip=true integration-test \ | ||
| -Dspark-distro-tgz=$root/spark/*.tgz \ | ||
| $TEST_ROOT/integration-test/build/mvn clean -Ddownload.plugin.skip=true integration-test \ |
There was a problem hiding this comment.
Should be $TEST_ROOT/spark/build/mvn
There was a problem hiding this comment.
or $SPARK_REPO_ROOT/build/mvn perhaps
There was a problem hiding this comment.
Ah that's confusing because we're using the Maven bundled with Spark. We should just provide our own, no?
There was a problem hiding this comment.
I tried starting with that - but the two mavens I tried were incompatible and caused the spark-build to stall. This works for now and I like that we'll be using the same maven as the spark build, so, moving it in-repo will be easier as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that the test scripts do not necessarily have to be run from the top level of the repository.