This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Support custom labels on the driver pod. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
reviewed
Jan 17, 2017
| <td>(none)</td> | ||
| <td> | ||
| Custom labels that will be added to the driver pod. This should be a comma-separated list of label key-value pairs, | ||
| where each label is in the format <code><key>=<value></code>. |
There was a problem hiding this comment.
get rid of the < -- I think just <code>key=value</code> is clear enough
| @@ -184,7 +188,7 @@ private[spark] class Client( | |||
| kubernetesClient.pods().createNew() | |||
| .withNewMetadata() | |||
| .withName(kubernetesAppId) | |||
| .withLabels(selectors) | |||
| .addToLabels(resolvedSelectors) | |||
There was a problem hiding this comment.
ok to make this method change here but not in other places?
There was a problem hiding this comment.
In this context it's fine but this change is accidental and probably should be reverted to reduce the unnecessary diff.
|
@ash211 good call - tests caught some subtle mistakes in the logic. Fixed all the comments. |
mccheah
commented
Jan 17, 2017
| assert(driverPodLabels.get("label2") == "label2value", "Unexpected value for label2") | ||
| } | ||
|
|
||
| test("Run driver with custom labels") { |
There was a problem hiding this comment.
Ah this is a mistake in how the tests were adjusted.
ash211
approved these changes
Jan 19, 2017
|
LGTM. |
ash211
pushed a commit
that referenced
this pull request
Feb 8, 2017
* Support custom labels on the driver pod. * Add integration test and fix logic. * Fix tests * Fix minor formatting mistake * Reduce unnecessary diff
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Support custom labels on the driver pod. * Add integration test and fix logic. * Fix tests * Fix minor formatting mistake * Reduce unnecessary diff
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Support custom labels on the driver pod. * Add integration test and fix logic. * Fix tests * Fix minor formatting mistake * Reduce unnecessary diff
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
* Support custom labels on the driver pod. * Add integration test and fix logic. * Fix tests * Fix minor formatting mistake * Reduce unnecessary diff
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Support custom labels on the driver pod. * Add integration test and fix logic. * Fix tests * Fix minor formatting mistake * Reduce unnecessary diff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26.