Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Added reference YAML files for RBAC configs for driver and shuffle service #502

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Conversation

liyinan926
Copy link
Member

@liyinan926 liyinan926 commented Sep 21, 2017

What changes were proposed in this pull request?

Adds YAML files for reference RBAC configuration for the Spark driver and shuffle service. To complement apache-spark-on-k8s/userdocs#14.

Ref: #500.

How was this patch tested?

Manual tests pending.

@foxish @kimoonkim

@foxish foxish assigned kimoonkim and foxish and unassigned kimoonkim Sep 21, 2017
Copy link
Member

@kimoonkim kimoonkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

name: spark
namespace: default
---
apiVersion: rbac.authorization.k8s.io/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the ability to create services also? The headless service is enabled by default IIRC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@foxish
Copy link
Member

foxish commented Sep 22, 2017

Config LGTM, feel free to merge on green.

@liyinan926 liyinan926 merged commit 3eb04bb into apache-spark-on-k8s:branch-2.2-kubernetes Sep 22, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
echarles pushed a commit to datalayer-externals/spark that referenced this pull request Jun 10, 2022
### What changes were proposed in this pull request?
This pr aims upgrade scala-maven-plugin to 4.6.2

### Why are the changes needed?
This version brings some bug fix related to `Incremental compile`, although it seems that Spark has not encountered these issue:

- [Fix incremental compiler not being able to find JDK classes when compiler macros with Java 11, close apache-spark-on-k8s#502](davidB/scala-maven-plugin#608)
- [Fix incremental compilation on Java 11+, close apache-spark-on-k8s#600](davidB/scala-maven-plugin#609)

all changes as follows:

- davidB/scala-maven-plugin@4.6.1...4.6.2

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass Github Actions

Closes apache#36800 from LuciferYang/scala-maven-plugin-462.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants