This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Add message to redirect PRs upstream if possible #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to re-direct community dev upstream as much as possible. However, some contributions impact components (e.g. shuffle server) that do not yet exist upstream. To handle this, we decided to add this message and leave it up to developers, but encourage them to submit upstream unless it isn't feasible.
foxish
approved these changes
Jan 24, 2018
.github/PULL_REQUEST_TEMPLATE
Outdated
| Please consider whether your pull request can be submitted against the Apache Spark project, and submit there if possible. | ||
|
|
||
| If you have any questions about whether a PR should be submitted upstream or against this fork, | ||
| please feel free to ask on the Big Data SIG [slack channel](https://kubernetes.slack.com/), |
There was a problem hiding this comment.
Let's also add a link to the spark-dev mailing list here, and encourage use of that. Slack is good to keep around for questions about "where should this feature go?".
|
rerun integration test please |
felixcheung
approved these changes
Feb 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to re-direct community dev upstream as much as possible. However, some contributions impact components (e.g. shuffle server) that do not yet exist upstream. To handle this, we decided to add this message and leave it up to developers, but encourage them to submit upstream unless it isn't feasible.