Skip to content

feat: support plugin_metadata of apisix #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 28, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 linked an issue Sep 30, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Attention: Patch coverage is 38.09524% with 156 lines in your changes missing coverage. Please review.

Project coverage is 40.43%. Comparing base (c38ae66) to head (1c39d4c).
Report is 321 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apisix/plugin_metadata.go 4.39% 87 Missing ⚠️
pkg/providers/utils/manifest.go 54.16% 18 Missing and 4 partials ⚠️
...providers/k8s/configmap/translation/translation.go 0.00% 17 Missing ⚠️
pkg/apisix/nonexistentclient.go 9.09% 10 Missing ⚠️
pkg/apisix/resource.go 0.00% 8 Missing ⚠️
pkg/providers/k8s/configmap/translation/parse.go 55.55% 6 Missing and 2 partials ⚠️
pkg/apisix/cluster.go 94.11% 2 Missing ⚠️
...ers/k8s/configmap/translation/configyaml_parser.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   40.89%   40.43%   -0.46%     
==========================================
  Files          78       82       +4     
  Lines        7231     7436     +205     
==========================================
+ Hits         2957     3007      +50     
- Misses       3933     4081     +148     
- Partials      341      348       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlinsRan AlinsRan marked this pull request as ready for review September 30, 2022 06:24
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Oct 8, 2022
@AlinsRan AlinsRan force-pushed the feat/plugin-metadata branch from abb63c3 to e0418ff Compare October 31, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Proposal: Add support for APISIXPluginMetadata function
4 participants