Skip to content

chore: remove support for Ingress in the extensions/v1beta1 API version #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

tao12345666333
Copy link
Member

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

closes: #1839

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels May 18, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone May 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #1840 (24dfc71) into master (3f45ca9) will increase coverage by 0.59%.
The diff coverage is 33.33%.

❗ Current head 24dfc71 differs from pull request most recent head b32805e. Consider uploading reports for the commit b32805e to get more accurate results

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
+ Coverage   39.87%   40.46%   +0.59%     
==========================================
  Files          92       92              
  Lines        7266     7095     -171     
==========================================
- Hits         2897     2871      -26     
+ Misses       3985     3841     -144     
+ Partials      384      383       -1     
Files Changed Coverage Δ
cmd/ingress/ingress.go 82.60% <ø> (-0.73%) ⬇️
pkg/providers/ingress/ingress.go 4.61% <0.00%> (-0.38%) ⬇️
pkg/providers/ingress/translation/translator.go 0.00% <ø> (ø)
pkg/providers/utils/ingress_status.go 31.03% <ø> (-6.47%) ⬇️
pkg/config/config.go 64.64% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 requested review from AlinsRan and lingsamuel and removed request for AlinsRan August 3, 2023 01:08
@tao12345666333 tao12345666333 merged commit 3fa789d into apache:master Aug 3, 2023
@tao12345666333 tao12345666333 deleted the rm-extensions/v1beta1 branch August 3, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
Development

Successfully merging this pull request may close these issues.

NOTICE: remove support for Ingress in the extensions/v1beta1 API version
4 participants