Skip to content

chore: add Gallardot for deps reviewer #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

tao12345666333
Copy link
Member

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

@Gallardot helped us review a lot of PRs, I think we can add him as a default reviewer.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333
Copy link
Member Author

wait for @Gallardot 's response.

@codecov-commenter
Copy link

Codecov Report

Merging #1942 (acbdb80) into master (e0a2b17) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head acbdb80 differs from pull request most recent head 39a93b2. Consider uploading reports for the commit 39a93b2 to get more accurate results

@@           Coverage Diff           @@
##           master    #1942   +/-   ##
=======================================
  Coverage   40.47%   40.47%           
=======================================
  Files          92       92           
  Lines        7100     7100           
=======================================
  Hits         2874     2874           
  Misses       3842     3842           
  Partials      384      384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tao12345666333. Glad to be the reviewer.

@tao12345666333 tao12345666333 merged commit cf88af9 into apache:master Aug 29, 2023
@tao12345666333 tao12345666333 deleted the add-reviewer branch August 29, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants