fix: attempt to shut down when provider init fails #2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
|
would be great if a maintainer could look at this eventually |
|
@Revolyssup sorry about the direct ping, are you still working on the ingress or could you direct me to someone who can help? |
pietrogoddibit2win
approved these changes
Oct 8, 2024
Revolyssup
approved these changes
Oct 10, 2024
Ben10k
approved these changes
Oct 11, 2024
|
Hey @AlinsRan, could you please take a look at this when you have a chance? Your review would help us keep things moving. Thanks a lot! |
Revolyssup
pushed a commit
that referenced
this pull request
Mar 17, 2025
Revolyssup
pushed a commit
to Revolyssup/apisix-ingress-controller
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1980.
Simpler version of #2152 that shouldn't break any tests, since it doesn't touch leader election.
Also addresses #2236.
This one just adds communicating failure from
runback toRun, tried to shut down gracefully, but forces a shutdown after 5 seconds.Still wouldn't recommend running two replicas, the code has some potential races.