fix: can not get hostname in redhat #12267
Open
+33
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
Hi @xuruidong, can you create an issue first and include minimal steps to reproduce it? |
done |
bzp2010
reviewed
May 31, 2025
|
|
||
| else | ||
| hostname = "unknown" | ||
| log.error("failed to read output of \"/bin/hostname\": ", err) | ||
| log.error("gethostname error:", ffi_string(C.strerror(ffi.errno()))) |
There was a problem hiding this comment.
Perhaps we can obtain the hostname by reading /proc/sys/kernel/hostname?
The /bin/hostname requires a binary, but as long as procfs exists, the above path will reflect the hostname, which may be more reliable. 🤔
The gethostname may behave differently on various Linux kernels and libc implementations, such as the maximum length of hostname. I noticed that you assumed it to be 256. It seems that this is not good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I use docker image apache/apisix:3.11.0-redhat , and get an error from the log: "sh: /bin/hostname: No such file or directory"
Which issue(s) this PR fixes:
Fixes # #12270
Checklist