GH-46547: [CI][Dev][R] Use pre-commit for lintr

[kou]

Rationale for this change

We want to migrate to pre-commit from archery lint.

What changes are included in this PR?

Use pre-commit for lintr against r/.

This doesn't use https://github.com/lorenzwalthert/precommit because it doesn't include cyclocomp that we need.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev][R] Use pre-commit for lintr #46547

[github-actions]

⚠️ GitHub issue #46547 has been automatically assigned in GitHub to PR creator.

[github-actions]

⚠️ GitHub issue #46547 has no components, please add labels for components.

[jonkeane]

The minimum supported version failure is spurious, but #46491 removes that anyway.

[jonkeane]

I'm good with this, we also might consider adding air to fix any linting issues as well (we can + should probably do that separately since we will need to reformat with air in one big change).

[kou]

OK. I've rebased on main and opened a new issue for Air: #46592

[assignUser]

Nice!

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1943911.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

[eitsupi]

I believe the tools directory is distributed as part of the source R package and is generally intended to be used to include files for use during source installation¹².
Since this script is used during development and is not needed during installation, probably it should be moved to a directory that is not included in the source R package (and is listed in .Rbuildignore).

If I understand correctly, the same reason why files like list.sh are not included in the subdirectory for now.

Footnotes

1. If your configure script needs auxiliary files, it is recommended that you ship them in a tools directory (as R itself does).https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Configure-and-cleanup-1 ↩

2. tools/: auxiliary files needed during configuration, usually found in the company of a configure script. https://r-pkgs.org/misc.html#other-directories ↩

[kou]

Good catch.
Could you open a new issue for it and discuss better location in the issue?

[eitsupi]

Sure. #46661