Skip to content

[refactor](type) Use PrimitiveType as template arg of data type #51201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

Gabriel39
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34034 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b93ecd0c017c28cab4c589d4b40179714237c39, data reload: false

------ Round 1 ----------------------------------
q1	26664	5097	5058	5058
q2	2090	302	193	193
q3	10471	1264	698	698
q4	10218	1013	525	525
q5	7621	2336	2366	2336
q6	185	162	131	131
q7	897	750	615	615
q8	9319	1245	1122	1122
q9	6861	5143	5191	5143
q10	6845	2320	1907	1907
q11	512	295	288	288
q12	337	344	210	210
q13	17778	3682	3101	3101
q14	251	229	216	216
q15	523	501	492	492
q16	428	431	378	378
q17	607	858	390	390
q18	7723	7339	7157	7157
q19	1546	955	560	560
q20	336	339	232	232
q21	3705	3145	2315	2315
q22	1059	1052	967	967
Total cold run time: 115976 ms
Total hot run time: 34034 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5142	5100	5070	5070
q2	247	330	226	226
q3	2166	2665	2296	2296
q4	1356	1866	1391	1391
q5	4501	4430	4364	4364
q6	210	169	123	123
q7	2021	1882	1726	1726
q8	2707	2537	2430	2430
q9	7229	7133	7123	7123
q10	3034	3199	2721	2721
q11	573	513	494	494
q12	677	775	596	596
q13	3565	3965	3189	3189
q14	287	290	269	269
q15	520	485	479	479
q16	448	485	451	451
q17	1146	1495	1382	1382
q18	7802	7493	7472	7472
q19	765	832	993	832
q20	2014	2037	1825	1825
q21	4746	4398	4335	4335
q22	1082	1047	1002	1002
Total cold run time: 52238 ms
Total hot run time: 49796 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186706 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8b93ecd0c017c28cab4c589d4b40179714237c39, data reload: false

query1	1010	488	505	488
query2	6555	1821	1815	1815
query3	6754	238	225	225
query4	26076	23585	23587	23585
query5	4402	660	472	472
query6	299	225	198	198
query7	4639	504	293	293
query8	315	277	243	243
query9	8628	2681	2660	2660
query10	486	329	266	266
query11	15213	15174	14876	14876
query12	167	114	110	110
query13	1664	540	437	437
query14	8852	6403	6192	6192
query15	197	200	177	177
query16	7138	649	507	507
query17	1192	729	566	566
query18	1999	392	301	301
query19	186	194	187	187
query20	123	118	117	117
query21	213	123	106	106
query22	4072	4144	3941	3941
query23	34248	33232	33182	33182
query24	8515	2395	2417	2395
query25	544	478	400	400
query26	1235	271	155	155
query27	2757	518	340	340
query28	4362	2121	2108	2108
query29	789	567	434	434
query30	281	218	181	181
query31	937	852	762	762
query32	73	66	65	65
query33	554	380	324	324
query34	805	873	526	526
query35	787	833	736	736
query36	965	996	881	881
query37	115	103	75	75
query38	4130	4237	4010	4010
query39	1511	1399	1419	1399
query40	221	125	108	108
query41	60	54	55	54
query42	120	111	111	111
query43	523	500	485	485
query44	1332	847	846	846
query45	177	178	170	170
query46	850	1029	642	642
query47	1766	1805	1716	1716
query48	391	438	312	312
query49	771	515	455	455
query50	655	698	404	404
query51	4152	4156	4067	4067
query52	114	109	99	99
query53	239	260	199	199
query54	592	578	517	517
query55	85	83	86	83
query56	310	323	355	323
query57	1125	1125	1091	1091
query58	266	263	266	263
query59	2647	2613	2613	2613
query60	333	339	306	306
query61	131	127	124	124
query62	814	716	677	677
query63	236	193	187	187
query64	4381	1023	683	683
query65	4274	4275	4229	4229
query66	1162	415	313	313
query67	16104	15512	15427	15427
query68	5554	924	546	546
query69	505	312	272	272
query70	1195	1141	1122	1122
query71	409	332	303	303
query72	5654	4727	4723	4723
query73	670	618	360	360
query74	8821	9057	8612	8612
query75	3181	3236	2722	2722
query76	3194	1198	758	758
query77	485	385	301	301
query78	9964	9956	9397	9397
query79	2633	815	593	593
query80	656	550	527	527
query81	507	268	218	218
query82	740	142	110	110
query83	266	266	266	266
query84	261	121	96	96
query85	886	456	321	321
query86	379	307	286	286
query87	4396	4442	4339	4339
query88	4022	2358	2359	2358
query89	400	314	288	288
query90	1873	215	273	215
query91	138	151	116	116
query92	76	63	57	57
query93	2582	939	581	581
query94	731	406	313	313
query95	388	292	285	285
query96	501	565	285	285
query97	2721	2771	2607	2607
query98	234	226	213	213
query99	1367	1409	1277	1277
Total cold run time: 272008 ms
Total hot run time: 186706 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.23 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b93ecd0c017c28cab4c589d4b40179714237c39, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.20	0.10
query5	0.46	0.43	0.43
query6	1.20	0.66	0.66
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.53	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.61	0.61	0.59
query14	0.78	0.85	0.80
query15	0.88	0.86	0.86
query16	0.39	0.39	0.39
query17	1.05	1.06	1.02
query18	0.23	0.21	0.21
query19	1.90	1.83	1.89
query20	0.01	0.02	0.01
query21	15.40	0.96	0.55
query22	0.74	1.25	0.76
query23	14.78	1.41	0.64
query24	7.45	1.24	0.69
query25	0.51	0.14	0.12
query26	0.56	0.18	0.13
query27	0.05	0.05	0.06
query28	9.52	0.95	0.46
query29	12.55	4.04	3.33
query30	0.25	0.09	0.06
query31	2.82	0.59	0.40
query32	3.24	0.54	0.46
query33	3.02	3.11	3.15
query34	15.71	5.16	4.55
query35	4.58	4.55	4.55
query36	0.67	0.50	0.47
query37	0.09	0.07	0.07
query38	0.04	0.04	0.05
query39	0.03	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.35 s
Total hot run time: 29.23 s

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34242 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dcc59afcee6c92cb7cc0b9c90ddbe3268113d6ab, data reload: false

------ Round 1 ----------------------------------
q1	27053	5091	5101	5091
q2	2092	298	195	195
q3	10479	1274	752	752
q4	10239	983	528	528
q5	7745	2395	2345	2345
q6	190	169	137	137
q7	940	763	630	630
q8	9314	1265	1133	1133
q9	6866	5162	5116	5116
q10	6899	2324	1890	1890
q11	482	283	269	269
q12	345	358	226	226
q13	17777	3691	3094	3094
q14	237	227	215	215
q15	538	483	485	483
q16	446	432	393	393
q17	620	879	374	374
q18	7755	7228	7194	7194
q19	1568	961	565	565
q20	338	352	244	244
q21	3947	2589	2390	2390
q22	1046	1024	978	978
Total cold run time: 116916 ms
Total hot run time: 34242 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5204	5102	5101	5101
q2	244	334	234	234
q3	2215	2634	2290	2290
q4	1370	1771	1477	1477
q5	4466	4435	4425	4425
q6	216	176	134	134
q7	2008	1963	1736	1736
q8	2593	2719	2593	2593
q9	7324	7258	7045	7045
q10	3032	3197	2760	2760
q11	580	526	502	502
q12	687	765	618	618
q13	3495	3933	3319	3319
q14	292	318	297	297
q15	561	492	481	481
q16	428	497	439	439
q17	1195	1559	1394	1394
q18	7732	7631	7406	7406
q19	843	855	869	855
q20	2003	2052	1867	1867
q21	4986	4497	4474	4474
q22	1106	1074	1024	1024
Total cold run time: 52580 ms
Total hot run time: 50471 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193653 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dcc59afcee6c92cb7cc0b9c90ddbe3268113d6ab, data reload: false

query1	1438	1112	1081	1081
query2	6199	1860	1816	1816
query3	11139	4752	4553	4553
query4	54482	24428	23040	23040
query5	4947	527	469	469
query6	352	222	202	202
query7	4888	538	308	308
query8	324	270	237	237
query9	5509	2631	2633	2631
query10	456	337	268	268
query11	15588	15068	14835	14835
query12	162	112	102	102
query13	1027	534	391	391
query14	10239	6401	6526	6401
query15	207	208	185	185
query16	7170	647	524	524
query17	1119	772	591	591
query18	1661	410	316	316
query19	202	187	172	172
query20	148	124	115	115
query21	213	138	105	105
query22	4505	4432	4326	4326
query23	34516	33641	33541	33541
query24	6560	2443	2478	2443
query25	471	506	416	416
query26	704	278	158	158
query27	2259	516	360	360
query28	2965	2153	2152	2152
query29	607	587	449	449
query30	278	214	190	190
query31	876	930	769	769
query32	71	67	62	62
query33	458	378	315	315
query34	798	921	546	546
query35	825	861	755	755
query36	975	1028	890	890
query37	117	105	76	76
query38	4331	4368	4276	4276
query39	1576	1491	1470	1470
query40	225	125	107	107
query41	55	55	52	52
query42	144	113	114	113
query43	512	555	498	498
query44	1392	855	854	854
query45	177	179	184	179
query46	881	1041	655	655
query47	1883	1862	1797	1797
query48	420	431	332	332
query49	744	540	444	444
query50	702	723	416	416
query51	4338	4237	4309	4237
query52	114	118	104	104
query53	242	274	200	200
query54	595	610	523	523
query55	90	91	90	90
query56	334	313	303	303
query57	1203	1249	1167	1167
query58	283	280	289	280
query59	2764	2829	2697	2697
query60	356	352	331	331
query61	150	146	154	146
query62	732	738	668	668
query63	231	196	199	196
query64	1834	1055	673	673
query65	4302	4308	4234	4234
query66	716	408	302	302
query67	15971	15952	15626	15626
query68	7540	919	523	523
query69	558	316	269	269
query70	1216	1147	1097	1097
query71	507	324	312	312
query72	5701	4891	4949	4891
query73	1532	733	357	357
query74	9012	9130	8857	8857
query75	3778	3217	2715	2715
query76	4225	1207	791	791
query77	593	393	321	321
query78	10068	10360	9488	9488
query79	1944	906	579	579
query80	608	510	467	467
query81	476	259	226	226
query82	467	127	96	96
query83	254	270	247	247
query84	291	114	89	89
query85	812	371	316	316
query86	416	287	282	282
query87	4446	4463	4322	4322
query88	3757	2328	2308	2308
query89	401	322	299	299
query90	1888	213	212	212
query91	153	147	116	116
query92	72	59	60	59
query93	1564	1019	578	578
query94	663	417	317	317
query95	377	304	293	293
query96	508	564	285	285
query97	2731	2750	2709	2709
query98	238	216	197	197
query99	1344	1421	1275	1275
Total cold run time: 299892 ms
Total hot run time: 193653 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dcc59afcee6c92cb7cc0b9c90ddbe3268113d6ab, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.10	0.12
query3	0.25	0.19	0.19
query4	1.59	0.20	0.12
query5	0.45	0.44	0.43
query6	1.15	0.67	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.54	0.51
query10	0.58	0.60	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.80	0.81	0.80
query15	0.89	0.86	0.87
query16	0.39	0.39	0.40
query17	1.06	1.06	1.07
query18	0.22	0.22	0.22
query19	1.92	1.89	1.84
query20	0.02	0.01	0.02
query21	15.40	0.92	0.53
query22	0.76	0.97	0.63
query23	15.24	1.44	0.61
query24	6.54	1.00	0.98
query25	0.52	0.16	0.16
query26	0.57	0.17	0.13
query27	0.06	0.06	0.06
query28	10.09	0.99	0.45
query29	12.55	3.94	3.29
query30	0.27	0.10	0.06
query31	2.82	0.61	0.39
query32	3.24	0.56	0.47
query33	3.02	3.12	3.01
query34	15.72	5.11	4.54
query35	4.61	4.59	4.56
query36	0.67	0.51	0.48
query37	0.09	0.07	0.06
query38	0.06	0.05	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.67 s
Total hot run time: 29.38 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 27, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 67126a3 into apache:master May 27, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants