-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-17709. [ARR] Add async responder and async handler performance metrics. #7292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
7cb0ddf
to
02381aa
Compare
@Hexiaoqiao @KeeProMise Sir, please help review this PR when you have free time, Thanks a lot. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
ThreadLocalContext threadLocalContext = new ThreadLocalContext(); | ||
asyncCompleteWith(responseFuture.handleAsync((result, e) -> { | ||
FederationRPCMetrics.ASYNC_RESPONDER_START_TIME.set(Time.monotonicNow()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hfutatzhanghb If thread local variables are used, it is recommended to use ThreadLocalContext, refer to startUpTime and proxyOpTime; because the response of a request may be processed by async responder or async handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @KeeProMise . I think using ThreadLocalContext here will cause this metrics not accurate. What's your opinion? Hope to receive from you! Thanks.
💔 -1 overall
This message was automatically generated. |
616d707
to
15cc381
Compare
82bccee
to
ad83682
Compare
1073071
to
474c8c6
Compare
💔 -1 overall
This message was automatically generated. |
Description of PR
Refer to HDFS-17709.
Add metrics to measure the performance of async responder thread.
This metric can guide us to tune the async responder thread pool.