YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… #7331

ferdelyi · 2025-01-27T15:38:39Z

… by Leaf Queues chart partition-aware

Description of PR

When partitions are used, the "Cluster Resource Usage By Leaf Queues" chart shows data only for the default partition and does not display metrics for the other partitions. Adding a separate chart for each partition and to re-structure the page based on categories for more clarity.

How was this patch tested?

Manually tested in my local environment. Screenshots provided in the Jira.

For code changes:

[ x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-01-27T17:40:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 3s		trunk passed
+1 💚	shadedclient	78m 56s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	37m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		120m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/1/artifact/out/Dockerfile
GITHUB PR	#7331
Optional Tests	dupname asflicense shadedclient codespell detsecrets jshint
uname	Linux 45d70d289fe3 5.15.0-125-generic #135-Ubuntu SMP Fri Sep 27 13:53:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b98420a`
Max. process+thread count	542 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-01-28T11:46:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	19m 10s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 23s		trunk passed
+1 💚	shadedclient	78m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	37m 32s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		137m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/2/artifact/out/Dockerfile
GITHUB PR	#7331
Optional Tests	dupname asflicense shadedclient codespell detsecrets jshint
uname	Linux 20612bc81d24 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ae93820`
Max. process+thread count	592 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

K0K0V0K · 2025-01-28T13:40:22Z

Thanks @ferdelyi for the upgrade!

LGTM

brumi1024

Thanks @ferdelyi for the patch, a debug log is left in the code (probably by accident), apart from that LGTM.

...project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/queue-usage-donut-chart.js

… by Leaf Queues chart partition-aware

hadoop-yetus · 2025-02-12T21:49:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 24s		trunk passed
+1 💚	shadedclient	79m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	37m 52s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		120m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/3/artifact/out/Dockerfile
GITHUB PR	#7331
Optional Tests	dupname asflicense shadedclient codespell detsecrets jshint
uname	Linux d79cc2443571 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `646ff86`
Max. process+thread count	525 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7331/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

brumi1024

Thanks for the update, LGTM.

brumi1024

Thanks for the update, LGTM.

brumi1024 · 2025-02-13T13:04:41Z

Thanks @ferdelyi for the patch, @K0K0V0K for the review, merging to trunk.

apache#7331)

github-actions bot added YARN trunk labels Jan 27, 2025

ferdelyi force-pushed the YARN-11758 branch from b98420a to ae93820 Compare January 28, 2025 09:28

K0K0V0K approved these changes Jan 28, 2025

View reviewed changes

brumi1024 reviewed Feb 11, 2025

View reviewed changes

...project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/components/queue-usage-donut-chart.js Outdated Show resolved Hide resolved

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage…

646ff86

… by Leaf Queues chart partition-aware

ferdelyi force-pushed the YARN-11758 branch from ae93820 to 646ff86 Compare February 12, 2025 19:47

ferdelyi requested a review from brumi1024 February 12, 2025 19:48

brumi1024 approved these changes Feb 13, 2025

View reviewed changes

brumi1024 merged commit 2291fab into apache:trunk Feb 13, 2025
4 checks passed

adideshpande pushed a commit to adideshpande/hadoop that referenced this pull request Feb 27, 2025

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… (

655038a

apache#7331)

YanivKunda pushed a commit to YanivKunda/hadoop that referenced this pull request Mar 23, 2025

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… (

caff5cd

apache#7331)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… #7331

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… #7331

Uh oh!

ferdelyi commented Jan 27, 2025

Uh oh!

hadoop-yetus commented Jan 27, 2025

Uh oh!

hadoop-yetus commented Jan 28, 2025

Uh oh!

K0K0V0K commented Jan 28, 2025

Uh oh!

brumi1024 left a comment

Uh oh!

Uh oh!

hadoop-yetus commented Feb 12, 2025

Uh oh!

brumi1024 left a comment

Uh oh!

brumi1024 left a comment

Uh oh!

brumi1024 commented Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… #7331

YARN-11758. [UI2] On the Cluster Metrics page make the Resource Usage… #7331

Uh oh!

Conversation

ferdelyi commented Jan 27, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jan 27, 2025

Uh oh!

hadoop-yetus commented Jan 28, 2025

Uh oh!

K0K0V0K commented Jan 28, 2025

Uh oh!

brumi1024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Feb 12, 2025

Uh oh!

brumi1024 left a comment

Choose a reason for hiding this comment

Uh oh!

brumi1024 left a comment

Choose a reason for hiding this comment

Uh oh!

brumi1024 commented Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!