-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part8. #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18ab889
to
6fdb4d9
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thank you @slfan1989 .
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,LGTM @slfan1989
@cnauroth @zhtttylz Thank you so much for reviewing the code. After giving it some careful thought, I've decided to merge this PR into the trunk branch. Although I have some concerns about potential issues, we need to take this step. If any problems arise, I'll make sure to address them promptly. cc: @steveloughran @ayushtkn @anujmodi2021 @Hexiaoqiao @szetszwo @jojochuang |
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part8.
How was this patch tested?
Junit test & mvn clean test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?