Skip to content

refactor: CollectAccounts now uses simple ApiCollector #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

sstojak1
Copy link
Contributor

@sstojak1 sstojak1 commented Sep 18, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
CollectAccounts is now using the simple ApiCollector.

Does this close any open issues?

Closes 8066

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.
You can test this by creating a new Devlake Project that will scrape data from SonarQube.
What you should notice is that there won't be duplicate date in _raw_sonarqube_api_accounts table after each pipeline run.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/refactor This PR refactors existing features labels Sep 18, 2024
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@klesh klesh merged commit 3367db4 into apache:main Sep 23, 2024
14 checks passed
sstojak1 added a commit to sstojak1/incubator-devlake that referenced this pull request Oct 25, 2024
klesh pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor][SonarQube] Change accounts collector
2 participants