Skip to content

BXMSDOC-3050-alternative: New kie-docs master #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

sterobin
Copy link
Contributor

@sterobin sterobin commented Aug 27, 2018

Restructured kie-docs master. See JIRA for details.

@sterobin
Copy link
Contributor Author

ok to test

@jomarko
Copy link
Contributor

jomarko commented Aug 29, 2018

Please remove ./doc-content/shared-kie-docs/src/main/asciidoc/shared/images, it is empty.

@jomarko
Copy link
Contributor

jomarko commented Aug 29, 2018

Please remove :imagesdir: attribute from files:

  • doc-content/drools-docs/src/main/asciidoc/ReleaseNotes/ReleaseNotesDrools.7.0.0.Final-section.adoc
  • doc-content/jbpm-docs/src/main/asciidoc/ReleaseNotes/Release.7.11.0.Final-section.adoc

@jomarko
Copy link
Contributor

jomarko commented Aug 29, 2018

You mentioned this change is ongoing, however just for record, update readme.

@jomarko
Copy link
Contributor

jomarko commented Aug 29, 2018

Please remove :images:dir attribute from assemblies folder. Given files can be found as:

cd kie-docs/assemblies;
grep -r -i ":imagesdir:";

I believe this can be done because there is no image referenced. Confirmed as:

cd kie-docs/assemblies;
grep -r -i "image::";

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just some minor additional cleanup needed, then good to merge.

@sterobin
Copy link
Contributor Author

Thanks @jomarko. Removed empty shared images folder and a couple of stray :imagesdir:. The ones in the assemblies are in fact required. I'll update the README in a separate push, after rebase.

@sterobin sterobin force-pushed the BXMSDOC-3050-alternative branch 5 times, most recently from 8cdc55a to 18255ae Compare August 30, 2018 22:01
@sterobin sterobin force-pushed the BXMSDOC-3050-alternative branch from 5d0b2d3 to 4d7b690 Compare August 30, 2018 22:13
@sterobin sterobin changed the title DO NOT MERGE: BXMSDOC-3050-alternative (for upstream master): Restructured kie-docs repo BXMSDOC-3050-alternative (for upstream master): Restructured kie-docs repo Aug 30, 2018
@sterobin sterobin changed the title BXMSDOC-3050-alternative (for upstream master): Restructured kie-docs repo BXMSDOC-3050-alternative: New kie-docs master Aug 30, 2018
@sterobin sterobin merged commit c77add4 into apache:master Aug 30, 2018
@sterobin sterobin deleted the BXMSDOC-3050-alternative branch November 12, 2019 17:35
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants