Skip to content

BXMSDOC-3202-master: Single-source DMN content between community and enterprise. #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

sterobin
Copy link
Contributor

@sterobin sterobin commented Sep 5, 2018

Ready for upstream master.

See JIRA for details.

@sterobin
Copy link
Contributor Author

sterobin commented Sep 5, 2018

Jenkins retest this please

@sterobin
Copy link
Contributor Author

sterobin commented Sep 5, 2018

ok to test

@sterobin
Copy link
Contributor Author

sterobin commented Sep 5, 2018

Jenkins retest this please

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sterobin

I have checked using the following links which you provided:
http://file.rdu.redhat.com/~sterobin/BXMSDOC-DMN_DROOLS/target/generated-docs/html_single/#drools.DMN
http://file.rdu.redhat.com/~sterobin/BXMSDOC-DMN_DM/

Generally to me looks more than fine, this is a very good advantage of the single source!! Thanks for pushing this work forward!

I have noticed this couple small details, I don't know if they were introduced by mistake on this PR, or is something about the rendering.. if you could kindly take a look?

  1. This property for some reason is highlighted with light red color:
    image

  2. This for some reason is highlighted in Java but not really necessary (for instance "Age" is in bold font)
    image

If this will need be managed in a separate PR is fine for me, reason why I'm approving, I mainly skimmed both Community and Product docs and seems to me the name variable is applied correctly where expected.

@pszubiak
Copy link

pszubiak commented Sep 6, 2018

Jenkins retest this please

@sterobin
Copy link
Contributor Author

sterobin commented Sep 6, 2018

@tarilabs I noticed the same thing! This is actually apparent in several other places in the Drools doc, outside of this PR. I've looked at the source and see absolutely no difference between the highlighted and bolded portions and other normal-looking portions. Same in other places. I think it might be an anomolous asciidoc rendering issue or something. I'll continue to keep my eye out for a reason for this.

Thanks Matteo!

@tarilabs
Copy link
Member

tarilabs commented Sep 6, 2018

it might be an anomolous asciidoc rendering issue or something.

Just a wild guess, could it be the "default" language for the verbatim? To try mitigate I would try specify a "no-language" for the source section, if it does exists in the asciidoc format.

@sterobin
Copy link
Contributor Author

sterobin commented Sep 6, 2018

@tarilabs, good point. I'll play around.

@sterobin
Copy link
Contributor Author

sterobin commented Sep 6, 2018

@tarilabs, I've just removed [source] from those two snippets entirely and they now render the same way as the others around it, which all do specify [source] for consistency. It's still mysterious why none of the other snippets specified with just [source] don't have the same issue. So it's fixed now, but not sure why. Anyway, thanks for letting me know.

@tarilabs
Copy link
Member

tarilabs commented Sep 6, 2018

I believe because as a global settings take "java" or another language, hence make a syntax highlight, and for the snippet in question, do apply different highlighting rule (as the snippet itself if pasted in the proper language, would have a slight difference in behavior I suppose or anyhow the parser for the syntax highlight might apply different rule)

@sterobin
Copy link
Contributor Author

sterobin commented Sep 6, 2018

@tarilabs, I don't understand, but that's okay. :) The main mystery for me is why in the properties doc there are 4 snippets in a row that are formatted identically and all render correctly except the last one. If it were a global thing, then all 4 snippets in that properties page would render in pink. I don't get it. Anyway, moving on for now I guess.

@sterobin sterobin force-pushed the BXMSDOC-3202-master branch from 0c53445 to aa0b565 Compare September 6, 2018 16:04
@sterobin sterobin changed the title WIP: BXMSDOC-3202-master: Single-source DMN content between community and enterprise. BXMSDOC-3202-master: Single-source DMN content between community and enterprise. Sep 6, 2018
@sterobin sterobin merged commit 7d25710 into apache:master Sep 6, 2018
@sterobin sterobin deleted the BXMSDOC-3202-master branch November 12, 2019 17:35
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants