-
Notifications
You must be signed in to change notification settings - Fork 182
BXMSDOC-3202-master: Single-source DMN content between community and enterprise. #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins retest this please |
ok to test |
Jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sterobin
I have checked using the following links which you provided:
http://file.rdu.redhat.com/~sterobin/BXMSDOC-DMN_DROOLS/target/generated-docs/html_single/#drools.DMN
http://file.rdu.redhat.com/~sterobin/BXMSDOC-DMN_DM/
Generally to me looks more than fine, this is a very good advantage of the single source!! Thanks for pushing this work forward!
I have noticed this couple small details, I don't know if they were introduced by mistake on this PR, or is something about the rendering.. if you could kindly take a look?
-
This property for some reason is highlighted with light red color:
-
This for some reason is highlighted in Java but not really necessary (for instance "Age" is in bold font)
If this will need be managed in a separate PR is fine for me, reason why I'm approving, I mainly skimmed both Community and Product docs and seems to me the name variable is applied correctly where expected.
Jenkins retest this please |
@tarilabs I noticed the same thing! This is actually apparent in several other places in the Drools doc, outside of this PR. I've looked at the source and see absolutely no difference between the highlighted and bolded portions and other normal-looking portions. Same in other places. I think it might be an anomolous asciidoc rendering issue or something. I'll continue to keep my eye out for a reason for this. Thanks Matteo! |
Just a wild guess, could it be the "default" language for the verbatim? To try mitigate I would try specify a "no-language" for the source section, if it does exists in the asciidoc format. |
@tarilabs, good point. I'll play around. |
@tarilabs, I've just removed |
I believe because as a global settings take "java" or another language, hence make a syntax highlight, and for the snippet in question, do apply different highlighting rule (as the snippet itself if pasted in the proper language, would have a slight difference in behavior I suppose or anyhow the parser for the syntax highlight might apply different rule) |
@tarilabs, I don't understand, but that's okay. :) The main mystery for me is why in the properties doc there are 4 snippets in a row that are formatted identically and all render correctly except the last one. If it were a global thing, then all 4 snippets in that properties page would render in pink. I don't get it. Anyway, moving on for now I guess. |
0c53445
to
aa0b565
Compare
Ready for upstream master.
See JIRA for details.