Skip to content

BXMSDOC-3197-master: Updated BOM info in docs. #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

sterobin
Copy link
Contributor

@sterobin sterobin commented Sep 11, 2018

Ready for upstream master.

See JIRA for details.

@sterobin sterobin changed the title BXMSDOC-3197-master: Updated BOM info in docs. WIP: BXMSDOC-3197-master: Updated BOM info in docs. Sep 11, 2018
Copy link
Contributor

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

@@ -34,13 +34,14 @@ endif::OP[]
// For copyright
:YEAR: 2018

// Maven info, from https://mvnrepository.com/artifact/org.kie/kie-bom?repo=redhat-ga
// Maven info, from https://mvnrepository.com (public repo) or https://repository.jboss.org/nexus/index.html#welcome (Nexus repo)
:MAVEN_ARTIFACT_VERSION: 7.7.0.Final-redhat-7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value will change and will be probably 7.11.0.Final-redhat-00002

@@ -34,13 +34,14 @@ endif::OP[]
// For copyright
:YEAR: 2018

// Maven info, from https://mvnrepository.com/artifact/org.kie/kie-bom?repo=redhat-ga
// Maven info, from https://mvnrepository.com (public repo) or https://repository.jboss.org/nexus/index.html#welcome (Nexus repo)
:MAVEN_ARTIFACT_VERSION: 7.7.0.Final-redhat-7
:BOM_VERSION: 7.0.0.GA-redhat-3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value needs to be updated too. It will be probably 7.1.0.GA-redhat-00002

@sterobin
Copy link
Contributor Author

Thank you @mareknovotny and @pszubiak! And yes, thank you Piotr about the versions. I assumed we didn't have the expected versions yet and we usually do a final update close to the release. Glad to know what it should be.

Copy link

@pszubiak pszubiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good

@sterobin sterobin changed the title WIP: BXMSDOC-3197-master: Updated BOM info in docs. BXMSDOC-3197-master: Updated BOM info in docs. Sep 12, 2018
@sterobin sterobin merged commit aa2b3a0 into apache:master Sep 12, 2018
@sterobin sterobin deleted the BXMSDOC-3197-master branch November 12, 2019 17:34
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants