-
Notifications
You must be signed in to change notification settings - Fork 182
BXMSDOC-3197-master: Updated BOM info in docs. #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good
_artifacts/document-attributes.adoc
Outdated
@@ -34,13 +34,14 @@ endif::OP[] | |||
// For copyright | |||
:YEAR: 2018 | |||
|
|||
// Maven info, from https://mvnrepository.com/artifact/org.kie/kie-bom?repo=redhat-ga | |||
// Maven info, from https://mvnrepository.com (public repo) or https://repository.jboss.org/nexus/index.html#welcome (Nexus repo) | |||
:MAVEN_ARTIFACT_VERSION: 7.7.0.Final-redhat-7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value will change and will be probably 7.11.0.Final-redhat-00002
_artifacts/document-attributes.adoc
Outdated
@@ -34,13 +34,14 @@ endif::OP[] | |||
// For copyright | |||
:YEAR: 2018 | |||
|
|||
// Maven info, from https://mvnrepository.com/artifact/org.kie/kie-bom?repo=redhat-ga | |||
// Maven info, from https://mvnrepository.com (public repo) or https://repository.jboss.org/nexus/index.html#welcome (Nexus repo) | |||
:MAVEN_ARTIFACT_VERSION: 7.7.0.Final-redhat-7 | |||
:BOM_VERSION: 7.0.0.GA-redhat-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value needs to be updated too. It will be probably 7.1.0.GA-redhat-00002
Thank you @mareknovotny and @pszubiak! And yes, thank you Piotr about the versions. I assumed we didn't have the expected versions yet and we usually do a final update close to the release. Glad to know what it should be. |
2d56109
to
5034e3c
Compare
5034e3c
to
668b4cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good
Ready for upstream master.
See JIRA for details.