Skip to content

BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording. #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

sterobin
Copy link
Contributor

@sterobin sterobin commented Sep 8, 2020

@karreiro @yesamer @hmanwani-rh ready for your review.

Links:

@sterobin sterobin added the under review Label for PRs pending SME or peer review label Sep 8, 2020
@sterobin sterobin requested review from yesamer and removed request for jomarko September 8, 2020 21:25
Copy link
Contributor

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterobin Thank you so much for correcting this. looks good
Thanks again

Copy link

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterobin @karreiro Changes are fine to me.
I have an optional comment, please evaluate if reasonable or not.
In my understanding DMN 1.1 and 1.3 versions are not supported currently, but a future implementation is planned. Maybe we can underline this in the docs.
eg. Writing DMN 1.1 and 1.3 models are currently not supported in the DMN designer in {CENTRAL}., WDYT?

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sterobin.

@sterobin
Copy link
Contributor Author

sterobin commented Sep 9, 2020

@yesamer Good point. Done. Added "currently" to all those instances about DMN 1.1 and 1.3 models not supported. Thanks!

@sterobin sterobin merged commit 35a03a2 into apache:master Sep 9, 2020
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
* BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording.

* Tweak DMN model support wording.
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
* BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording.

* Tweak DMN model support wording.
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
* BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording.

* Tweak DMN model support wording.
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
* BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording.

* Tweak DMN model support wording.
tkobayas pushed a commit that referenced this pull request May 8, 2025
* BXMSDOC-6415-master: Update DMN 1.1 and 1.3 wording.

* Tweak DMN model support wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under review Label for PRs pending SME or peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants