Skip to content

BXMSDOC-6656 RN update DTAnalysis wired plugin (Kie7 RN) #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Oct 6, 2020

https://issues.redhat.com/browse/BXMSDOC-6656

this first PR addresses the need for the RN update on the Drools/Kie7 side

@tarilabs tarilabs requested a review from hmanwani-rh October 6, 2020 15:29
@sterobin sterobin requested review from sterobin and removed request for hmanwani-rh October 6, 2020 17:07
@sterobin
Copy link
Contributor

sterobin commented Oct 6, 2020

@hmanwani-rh I'll take it this time, and will apply the same to Kogito. Will also see if I can update the docs somewhere relevant also. Probably tomorrow.

@sterobin sterobin added the under review Label for PRs pending SME or peer review label Oct 6, 2020
@hmanwani-rh
Copy link
Contributor

@hmanwani-rh I'll take it this time, and will apply the same to Kogito. Will also see if I can update the docs somewhere relevant also. Probably tomorrow.

thanks @sterobin

@sterobin sterobin requested a review from hmanwani-rh October 7, 2020 11:48
Copy link
Contributor

@sterobin sterobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarilabs @hmanwani-rh I pushed a commit to expand the docs around this for community and enterprise with a new "Configurable DMN validation" section. I also aligned the structures of the previous and new release notes just for consistency. Will do the same for Kogito when @tarilabs has that one.

Links:

@sterobin
Copy link
Contributor

sterobin commented Oct 7, 2020

Jenkins retest this please

Copy link
Member Author

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, but I believe as you edited the 7.34 Release Notes you inadvertently copied a paragraph twice, below?

Copy link
Contributor

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterobin Looks good to me, thanks

@sterobin sterobin force-pushed the tarilabs-20201006-BXMSDOC-6656 branch from e12ee67 to 11bf452 Compare October 7, 2020 14:23
@sterobin
Copy link
Contributor

sterobin commented Oct 7, 2020

@hmanwani-rh Please note that this is for master only because it applies to 7.10, NOT 7.9 (for community release 7.45 and beyond). So this release note and doc update will be available to you post 7.9. If you do any other 7.9 to the DMN content, just note that this PR content will not be carried over from master when you cherry-pick subsequent changes. Let me know if anything about this is unclear. Thanks.

@hmanwani-rh
Copy link
Contributor

@hmanwani-rh Please note that this is for master only because it applies to 7.10, NOT 7.9 (for community release 7.45 and beyond). So this release note and doc update will be available to you post 7.9. If you do any other 7.9 to the DMN content, just note that this PR content will not be carried over from master when you cherry-pick subsequent changes. Let me know if anything about this is unclear. Thanks.

@sterobin Got it, thanks for letting me know.

@sterobin sterobin removed the under review Label for PRs pending SME or peer review label Oct 7, 2020
@sterobin sterobin merged commit 5b99b46 into apache:master Oct 7, 2020
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
tkobayas pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants