Skip to content

[Business Central] KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Nov 13, 2020

JIRA: KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation

Now the DMN Designer supports 1.1 and 1.3 models, non including DMN 1.3 features, when users that import assets on Kogito or Business Central . However, when users save their models, we're still saving them as DMN 1.2 models.

Thus, I've updated everything related to the DMN versions support, and also I've added an entry in the release notes section (I'm not sure if I should update the doc-content/enterprise-only/release-notes/rn-whats-new-con.adoc, I've noticed there are items from the latest version there). Please, let me know if it needs any change :-)

@hmanwani-rh hmanwani-rh added do not merge kogito under review Label for PRs pending SME or peer review and removed do not merge kogito labels Nov 16, 2020
Copy link
Contributor

@hmanwani-rh hmanwani-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karreiro Have made some tweaks to the content. Also, regarding the What's new in PAM/DM, we create a JIRA and provide a description for new features in the same JIRA. Therefore, I have removed the content from doc-content/enterprise-only/release-notes/rn-whats-new-con.adoc and saved it locally to add the content once our what's new JIRA will be created for 7.10.

Please review those changes and share your feedback.

Following are the doc previews for the community and enterprise version:
Enterprise version
Developing Decision Services in Red Hat Process Automation Manager
Developing Decision Services in Red Hat Decision Manager

Community version
Drools documentation

@karreiro karreiro requested review from jstastny-cz and removed request for jstastny-cz November 18, 2020 12:52
@karreiro
Copy link
Contributor Author

Thank you, @hmanwani-rh! I just reviewed your changes, and they look great to me, thanks :-)

@karreiro karreiro requested review from danielzhe and removed request for jstastny-cz November 18, 2020 12:58
Copy link
Contributor

@csherrar csherrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a single wording suggestion for translate-ability, this looks good to me.


= Support for DMN 1.1 and DMN 1.3 assets in DMN designer

You can now use the DMN designer in {CENTRAL} to open DMN 1.1 or a DMN 1.3 assets. {PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can design your DMN models directly in {CENTRAL} or import existing DMN models into your {PRODUCT} projects for deployment and execution. Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/You can now use the DMN designer in {CENTRAL} to open DMN 1.1 or a DMN 1.3 assets./You can now open DMN 1.1 or a DMN 1.3 assets in the DMN designer in {CENTRAL}. {

s/Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models./If you import DMN 1.1 and 1.3 models (that do not contain DMN 1.3 features) into {CENTRAL}, and open and save them in the DMN designer, the models are converted to DMN 1.2 models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csherrar Thanks for your review.
+1 for the first suggestion. However, regarding the second sentence, the 1.1 and 1.3 models are first opened and then only saved as 1.2 models, this means that the conversion happens along with the saving step. Therefore, I would suggest keeping the Any DMN 1.1 and 1.3 models sentence as is to eliminate the confusion.

wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed, thanks Heena!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -4,7 +4,7 @@
{PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can integrate DMN models with your {PRODUCT} decision services in several ways:

* Design your DMN models directly in {CENTRAL} using the DMN designer.
* Import DMN files into your project in {CENTRAL} (*Menu -> Design -> Projects -> Import Asset*). DMN 1.1 and 1.3 models are currently not supported in the DMN designer in {CENTRAL}.
* Import DMN files into your project in {CENTRAL} (*Menu -> Design -> Projects -> Import Asset*). Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models./If you import DMN 1.1 and 1.3 models (that do not contain DMN 1.3 features) into {CENTRAL}, and open and save them in the DMN designer, the models are converted to DMN 1.2 models.

Copy link
Contributor

@hmanwani-rh hmanwani-rh Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it as is, as discussed in the previous comment

@@ -1,7 +1,7 @@
[id='dmn-model-creating-proc_{context}']
= Creating and editing DMN models in {CENTRAL}

You can use the DMN designer in {CENTRAL} to design DMN decision requirements diagrams (DRDs) and define decision logic for a complete and functional DMN decision model. {PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and includes enhancements and fixes to FEEL and DMN model components to optimize the experience of implementing DMN decision services with {PRODUCT}. {PRODUCT} also provides runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. DMN 1.1 and 1.3 models are currently not supported in the DMN designer in {CENTRAL}.
You can use the DMN designer in {CENTRAL} to design DMN decision requirements diagrams (DRDs) and define decision logic for a complete and functional DMN decision model. {PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and includes enhancements and fixes to FEEL and DMN model components to optimize the experience of implementing DMN decision services with {PRODUCT}. {PRODUCT} also provides runtime-only support for DMN 1.1 and 1.3 models at conformance level 3, but any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, but any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models./. If you import DMN 1.1 and 1.3 models (that do not contain DMN 1.3 features) into {CENTRAL}, and open and save them in the DMN designer, the models are converted to DMN 1.2 models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it as is, as discussed in the previous comment

@@ -14,4 +14,4 @@ A DMN conformance level 2 implementation includes the requirements in conformanc
Conformance level 3::
A DMN conformance level 3 implementation includes the requirements in conformance levels 1 and 2, and supports Friendly Enough Expression Language (FEEL) expressions, the full set of boxed expressions, and fully executable decision models.

{PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can design your DMN models directly in {CENTRAL} or import existing DMN models into your {PRODUCT} projects for deployment and execution. DMN 1.1 and 1.3 models are currently not supported in the DMN designer in {CENTRAL}.
{PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can design your DMN models directly in {CENTRAL} or import existing DMN models into your {PRODUCT} projects for deployment and execution. Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models./If you import DMN 1.1 and 1.3 models (that do not contain DMN 1.3 features) into {CENTRAL}, and open and save them in the DMN designer, the models are converted to DMN 1.2 models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it as is, as discussed in the previous comment

@@ -7,7 +7,7 @@ ifdef::context[:parent-context: {context}]
// Purpose statement for the assembly
As a business analyst or business rules developer, you can use Decision Model and Notation (DMN) to model a decision service graphically. The decision requirements of a DMN decision model are determined by a decision requirements graph (DRG) that is depicted in one or more decision requirements diagrams (DRDs). A DRD can represent part or all of the overall DRG for the DMN model. DRDs trace business decisions from start to finish, with each decision node using logic defined in DMN boxed expressions such as decision tables.

{PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can design your DMN models directly in {CENTRAL} or import existing DMN models into your {PRODUCT} projects for deployment and execution. DMN 1.1 and 1.3 models are currently not supported in the DMN designer in {CENTRAL}.
{PRODUCT} provides design and runtime support for DMN 1.2 models at conformance level 3, and runtime-only support for DMN 1.1 and 1.3 models at conformance level 3. You can design your DMN models directly in {CENTRAL} or import existing DMN models into your {PRODUCT} projects for deployment and execution. Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Any DMN 1.1 and 1.3 models (do not contain DMN 1.3 features) that you import into {CENTRAL}, open in the DMN designer, and save are converted to DMN 1.2 models./If you import DMN 1.1 and 1.3 models (that do not contain DMN 1.3 features) into {CENTRAL}, and open and save them in the DMN designer, the models are converted to DMN 1.2 models.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it as is, as discussed in the previous comment

@hmanwani-rh hmanwani-rh removed the under review Label for PRs pending SME or peer review label Nov 19, 2020
@vidya-iyengar
Copy link
Contributor

ok to test

@vidya-iyengar vidya-iyengar merged commit 7513a77 into apache:master Nov 19, 2020
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 7, 2025
…dels to version 1.2 - Documentation (apache#3066)

* KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation (Business Central)

* KOGITO-3807: Made some tweaks

* KOGITO-3807: Incorporated Clifton's suggestions

Co-authored-by: Heena Manwani <[email protected]>
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
…dels to version 1.2 - Documentation (apache#3066)

* KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation (Business Central)

* KOGITO-3807: Made some tweaks

* KOGITO-3807: Incorporated Clifton's suggestions

Co-authored-by: Heena Manwani <[email protected]>
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
…dels to version 1.2 - Documentation (apache#3066)

* KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation (Business Central)

* KOGITO-3807: Made some tweaks

* KOGITO-3807: Incorporated Clifton's suggestions

Co-authored-by: Heena Manwani <[email protected]>
tkobayas pushed a commit to tkobayas/kie-docs that referenced this pull request May 8, 2025
…dels to version 1.2 - Documentation (apache#3066)

* KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation (Business Central)

* KOGITO-3807: Made some tweaks

* KOGITO-3807: Incorporated Clifton's suggestions

Co-authored-by: Heena Manwani <[email protected]>
tkobayas pushed a commit that referenced this pull request May 8, 2025
…dels to version 1.2 - Documentation (#3066)

* KOGITO-3807: [DMN Designer] Convert DMN 1.1/1.3 models to version 1.2 - Documentation (Business Central)

* KOGITO-3807: Made some tweaks

* KOGITO-3807: Incorporated Clifton's suggestions

Co-authored-by: Heena Manwani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants