Skip to content

Replace tabs with whitespaces to fix rule indentation #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Jul 24, 2018

Hi @sterobin, during looking on BXMSDOC-2962, I notcied not ideal indentation in rule example shown below. I am trying to fix by this PR.

screenshot from 2018-07-24 08-47-51

@sterobin
Copy link
Contributor

@jomarko, thank you so much for you proactivity in this! Really means a lot to have you just dive in and propose PRs yourself. You may recall, though, that you and I actually iterated over this very code sample before, for alignment issues :) It's a tooling issue. I've found that trying white spaces or different types of tabs results in erratic output in the portal. So I know it's not ideal, but I'm not sure this PR actually fixes it, reliably anyway.

@jomarko
Copy link
Contributor Author

jomarko commented Jul 24, 2018

@sterobin please if there is way how can I build product version of docs locally, I will do and check the result.

@sterobin
Copy link
Contributor

@jomarko, to build locally from our project, you need to install ccutil if not installed already (just dnf or yum install ccutil, I think) then clone our build tool repo called "proposal-d" (https://gitlab.cee.redhat.com/red-hat-jboss-bxms-documentation/proposal-d/tree/master) and follow the readme instructions to set up. Then use the bxms-build script provided in that repo to build the output. It's a bit of a pain to set up, and even then the output appears like the previews I typically send you, which are close to how the content appears on the Portal but not exact.

Just FYI, our building process will be simplified substantially once we get "permission" from upstream doc guys to unify our content and to use a non-maven structure.

@jomarko jomarko closed this Jul 25, 2018
Rikkola pushed a commit to Rikkola/kie-docs that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants