Fix StringBuilder cache corruption on recursive access
#2275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
reviewed
Feb 9, 2024
There was a problem hiding this comment.
This certainly looks great and builds up on your work on main, but do we really need to backport StringBuilderRecycler to 2.x?
This is an edge case that is only triggered, if we two nested log calls. I would prefer a fix with the minimal amount of LOCs required. In this case I think that ParameterizedMessage needs a:
private static final ThreadLocal<AtomicInteger> recursionCount;field.
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java
Outdated
Show resolved
Hide resolved
You are right. I have changed the implementation as you suggested and it indeed looks better. 💯 Thanks for the review. 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.