-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Migrate 2.x
website to Antora
#2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@garydgregory shared some remarks in Slack. I will address them here.
Right. Fixed in 391e4ce.
It is not missing any. It has the identical content that we have today: https://web.archive.org/web/20231225134825/https://logging.apache.org/log4j/2.x/log4j-mongodb4.html If you are looking for the one in
Gary, I think you have a misunderstanding. Let me try to clarify certain things.
Yes, and no. Plugin reference is generated from the source code. It might not contain the most easy-to-understand introduction. OTOH, manual is hand-written. @ppkarwasz and my long-term plan is to link to plugin reference from manual, instead of duplicating the content there. For instance, manual should not explain the configuration options of
Replaced it with the green IntelliJ IDEA uses in 4701171.
Agreed. That is a styling issue, and I prefer to tackle that later on.
Yes, because I wanted it to contain the following sub-menus:
Since, there is already a
Right. This is due to the fact that the original source (Markdown, XDoc, etc.) was not indicating the language. I fixed whatever I can find in 234ac80.
Improved the navigation in 205f617. |
This PR migrates the
asciidoctor-maven-plugin
-based current website in2.x
to Antora with several other improvements.Rationale
Developers love AsciiDoc, but
asciidoctor-maven-plugin
falls short on addressing our needs to build a website from ~70 AsciiDoc files. In particular, the navigation (creating an overarching menu, breadcrumbs, etc.) is problematic; there is no easy way to tell the user at which level of the hierarchy they are standing at. Antora, the de facto offline site generator for AsciiDoc, address all these shortcomings and more.Deliverables
This PR implements the following deliverables
xref
, they are checked as a part of thesite
goal!)src/site
files are removedmaven-site-plugin
)pre-site
phase and outputs totarget/generated-site
instead. That is, compiledsrc/changelog
will not be dumped tosrc/site
anymore.constants.adoc
is directed totarget/generated-site
too (similar to release notes explained above)log4j-docgen-asciidoctor-extension
is ported to JavaScript to work as a Asciidoctor.js extension (since that is what Antora uses)target/site
with your browserReview kit
Don't be put down by the amount of changed files. Many are either removed (
_release_notes
,src/site/resources/css
, etc.) or slightly changed. Once you start scrolling down the changes, you will encounter the meat.How to build and view the website?