Skip to content

Commit e2f4888

Browse files
authored
Jira to Github issues (#175)
* Jira to Github issues * Use new pull_request_template.md
1 parent 7f5245c commit e2f4888

File tree

1 file changed

+13
-19
lines changed

1 file changed

+13
-19
lines changed

.github/pull_request_template.md

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
1-
Following this checklist to help us incorporate your
1+
Following this checklist to help us incorporate your
22
contribution quickly and easily:
33

4-
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed
5-
for the change (usually before you start working on it). Trivial changes like typos do not
6-
require a JIRA issue. Your pull request should address just this issue, without
7-
pulling in other changes.
8-
- [ ] Each commit in the pull request should have a meaningful subject line and body.
9-
- [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`,
10-
where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice
11-
is to use the JIRA issue title in the pull request title and in the first line of the
12-
commit message.
13-
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
14-
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
15-
be performed on your pull request automatically.
16-
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
4+
- [ ] Your pull request should address just one issue, without pulling in other changes.
5+
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
6+
- [ ] Each commit in the pull request should have a meaningful subject line and body.
7+
Note that commits might be squashed by a maintainer on merge.
8+
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
9+
This may not always be possible but is a best-practice.
10+
- [ ] Run `mvn verify` to make sure basic checks pass.
11+
A more thorough check will be performed on your pull request automatically.
12+
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
1713

1814
If your pull request is about ~20 lines of code you don't need to sign an
1915
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
2016
please ask on the developers list.
2117

22-
To make clear that you license your contribution under
18+
To make clear that you license your contribution under
2319
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
2420
you have to acknowledge this by using the following check-box.
2521

26-
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
27-
28-
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
29-
22+
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
23+
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

0 commit comments

Comments
 (0)