Skip to content

Jira to Github issues #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Jira to Github issues #175

merged 2 commits into from
May 7, 2025

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 5, 2025

No description provided.

@elharo elharo requested a review from slawekjaranowski May 5, 2025 15:20
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GitHub issues we use template such:
https://github.com/apache/maven-clean-plugin/blob/master/.github/pull_request_template.md

GitHub issue are not required, release-drafter generate release notes based on PR.

Issues are not mentioned in release notes.

@slawekjaranowski slawekjaranowski requested a review from Bukama May 5, 2025 16:20
@Bukama
Copy link
Contributor

Bukama commented May 5, 2025

For GitHub issues we use template such: https://github.com/apache/maven-clean-plugin/blob/master/.github/pull_request_template.md

GitHub issue are not required, release-drafter generate release notes based on PR.

Issues are not mentioned in release notes.

Can't add anything to this. All mentioned.

But yes at the start we had an old, non updated PR template. Please update to the one Slawek has linked.

Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@elharo
Copy link
Contributor Author

elharo commented May 7, 2025

flaky CI:

Caused by: java.io.IOException: Cannot run program "git" (in directory "/home/jenkins/jenkins-home/workspace/x_maven-checkstyle-plugin_PR-175@libs/a1b1c2dbea720dc5f71277f71d5801d2bb3525333474abba81df5d920d790b42"): error=0, Failed to exec spawn helper: pid: 3296325, exit value: 1

@Bukama Bukama requested a review from slawekjaranowski May 7, 2025 15:08
@elharo elharo merged commit e2f4888 into master May 7, 2025
51 checks passed
@elharo elharo deleted the elharo-patch-1 branch May 7, 2025 19:27
@github-actions github-actions bot added this to the 3.6.1 milestone May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants