[MINSTALL-205] Warning when using install-file in parallel builds

[jira-importer]

Gili opened MINSTALL-205 and commented

ePer the online documentation, install-file:

• Executes as an aggregator goal.
• The goal is thread-safe and supports parallel builds.

But when I use it in a parallel build I get this warning:

 

[WARNING] *****************************************************************
[WARNING] * The                                                           *
[WARNING] * org.apache.maven.plugins:maven-install-plugin:3.1.3:install-file *
[WARNING] * aggregator mojo is already being executed in this parallel    *
[WARNING] * build, those kind of mojos require exclusive access to        *
[WARNING] * reactor to prevent race conditions. This mojo execution will  *
[WARNING] * be blocked until the aggregator mojo is done.                 *
[WARNING] *****************************************************************

 

Expected behavior: If the plugin is safe for use in parallel builds, it should not trigger this warning.

---

Affects: 3.1.3, 4.0.0-beta-1

[jira-importer]

Gili commented

I am building with mvnw --strict-checksums --threads=1C

[jira-importer]

Gili commented

When I try version 4.0.0-beta-1 I get:

[WARNING] * Your build is requesting parallel execution, but this         *
[WARNING] * project contains the following plugin(s) that have goals not  *
[WARNING] * marked as thread-safe to support parallel execution.          *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against Apache Maven.                           *
[WARNING] *****************************************************************
[WARNING] The following goals are not marked as thread-safe in root:
[WARNING]   org.apache.maven.plugins:maven-install-plugin:4.0.0-beta-1:install
[WARNING] *****************************************************************

This seems to imply that either the documentation is wrong or the implementation is wrong. The documentation I am looking at is https://maven.apache.org/plugins/maven-install-plugin/install-mojo.html and https://maven.apache.org/plugins/maven-install-plugin/install-mojo.html

[jira-importer]

Piotr Zygielo commented

MNG-8186

[jira-importer]

Gili commented

Invoking mvn verify install:install causes the warning to disappear. I know that "mvn install" is not the same as "mvn install:install" but it's still not clear why the former would trigger a warning claiming that the "install" or "install-file" goals are not thread-safe when they are... This seems like a bug, no? If not, it would be helpful to clarify the documentation on this point.}}

[jira-importer]

Gili commented

For clarification, I have a multi-module project that depends on libraries that are missing {}module-info.java{}. Consequently, one of my sub-modules uses moditect-maven-plugin to add module-info.java files and repackage those libraries under a local groupId so that the final project's dependencies are all modularized. This is the only reason I am using "mvn install" instead of "mvn verify". To authors of the libraries in question have been unwilling to add "module-info.java" themselves :(

[jira-importer]

Gili commented

Piotr Zygielo Can you please elaborate? Which aggregator mojo is locking other mojo executions in this case? I still don't understand whether the documentation or implementation is wrong (or neither and something else is going on).

Thank you in advance.