Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] operator arctan2 #15890

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

tingying2020
Copy link
Contributor

New pr after rebase.

@tingying2020 tingying2020 requested a review from szha as a code owner August 14, 2019 09:01
def hybrid_forward(self, F, x1, x2):
return F.np.arctan2(x1, x2)

#Reduce dimension of src to dimention of des.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Reduce dimension of src to dimension of des.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tingying2020 tingying2020 force-pushed the ms_arctan2_new branch 6 times, most recently from 77fdfb2 to effd142 Compare September 16, 2019 07:34
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 self-assigned this Sep 16, 2019
@szha
Copy link
Member

szha commented Sep 17, 2019

@tingying2020 could you resolve conflicts?

@reminisce reminisce changed the base branch from master to numpy_staging_prs September 23, 2019 04:21
* change the test code

* add @use_np in test code

* only support float16, float32 and float64.

* fix format error

* remove redundant backslash

* change wrapper in symbol

* delete gpu test

* edit test

* change infer type

* remove redundant **kwargs

* change atol and rtol in test

* edit test shape
@reminisce reminisce merged commit 6e2a58d into apache:numpy_staging_prs Sep 23, 2019
reminisce pushed a commit that referenced this pull request Sep 23, 2019
* change the test code

* add @use_np in test code

* only support float16, float32 and float64.

* fix format error

* remove redundant backslash

* change wrapper in symbol

* delete gpu test

* edit test

* change infer type

* remove redundant **kwargs

* change atol and rtol in test

* edit test shape
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
* change the test code

* add @use_np in test code

* only support float16, float32 and float64.

* fix format error

* remove redundant backslash

* change wrapper in symbol

* delete gpu test

* edit test

* change infer type

* remove redundant **kwargs

* change atol and rtol in test

* edit test shape
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* change the test code

* add @use_np in test code

* only support float16, float32 and float64.

* fix format error

* remove redundant backslash

* change wrapper in symbol

* delete gpu test

* edit test

* change infer type

* remove redundant **kwargs

* change atol and rtol in test

* edit test shape
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants