Skip to content

[DO-NOT-MERGE] Investigating SparkR test failure #20005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

Don't merge this. I would like to check few things. I am super busy for the rest of this month so I wouldn't make it shortly.

Please keep investigating this if anyone is doing.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Dec 18, 2017

Test build #85033 has finished for PR 20005 at commit 6646eb5.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

I've tried to investigate this and I think it is due to a wrongly formatted document at https://cran.r-project.org/src/contrib/PACKAGES.in:

Package: alR
X-CRAN-Comment: Archived again on 2017-12-15 as none of the errors (failure to install with clang and on Solaris, buffer overflows) were corrected.

X-CRAN-History: Archived on 2017-12-01 as C++ errors (and segfaults) were not corrected despite reminders.
	Unarchived on 2017-12-07.

There is an additional breaking line here and it breaks the function tools:::.check_package_CRAN_incoming.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

Note: I've emailed to cran sysadmin team and asked them for help to fix the broken page.

@HyukjinKwon
Copy link
Member Author

I see. Nice to get some helps. BTW, this also seems related with specific R version as well. I wasn't able to reproduce this with R 3.4.0 but I am able to reproduce this with R 3.1.1 (same as Jenkins').

Probably, some corner cases were handled in tools:::.check_package_CRAN_incoming in the upper version.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

I use R version 3.2.3 and I can reproduce this too.

@HyukjinKwon
Copy link
Member Author

cc @shivaram, @felixcheung and @falaki too FYI.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

Oh, Thanks for cran sysadmin team's quick reply, they fixed that broken page.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

retest this please.

@HyukjinKwon
Copy link
Member Author

@viirya you are my hero.

@SparkQA
Copy link

SparkQA commented Dec 18, 2017

Test build #85045 has finished for PR 20005 at commit 6646eb5.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

retest this please.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

Verified locally, this issue fixed. Let's wait for Jenkins.

@HyukjinKwon
Copy link
Member Author

Just checked it passes with R 3.1.1 in my local too!

@SparkQA
Copy link

SparkQA commented Dec 18, 2017

Test build #85046 has finished for PR 20005 at commit 6646eb5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

I think we can safely resolve https://issues.apache.org/jira/browse/SPARK-22812. Let me leave this PR closed as well. Thanks to @viirya and CRAN sysadmin team.

@viirya
Copy link
Member

viirya commented Dec 18, 2017

Ok. tests passed. Looks good.

@falaki
Copy link
Contributor

falaki commented Dec 18, 2017

Thank you guys.

@felixcheung
Copy link
Member

felixcheung commented Dec 18, 2017 via email

@sameeragarwal
Copy link
Member

Thanks @viirya!

@HyukjinKwon HyukjinKwon deleted the investigating-cran branch January 2, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants