[SPARK-22827][SQL][FOLLOW-UP] Throw SparkOutOfMemoryError in HashAggregateExec, too.
#22969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -787,7 +789,7 @@ case class HashAggregateExec( | |||
| | $unsafeRowKeys, ${hashEval.value}); | |||
| | if ($unsafeRowBuffer == null) { | |||
| | // failed to allocate the first page | |||
| | throw new OutOfMemoryError("No enough memory for aggregation"); | |||
| | throw new $oomeClassName("No enough memory for aggregation"); | |||
There was a problem hiding this comment.
Hi, @ueshin . Is this the final place? If not, can we have a separate JIRA issue for this?
There was a problem hiding this comment.
Yes, I think so based on my investigation. I grep-ed with "OutOfMemoryError" and checked the suspicious places.
|
Test build #98577 has finished for PR 22969 at commit
|
|
Retest this please. |
dongjoon-hyun
approved these changes
Nov 8, 2018
cloud-fan
approved these changes
Nov 8, 2018
|
Test build #98585 has finished for PR 22969 at commit
|
|
Merged to master. |
|
Thank you, @ueshin and @cloud-fan . |
gatorsmile
reviewed
Nov 9, 2018
| @@ -787,7 +789,7 @@ case class HashAggregateExec( | |||
| | $unsafeRowKeys, ${hashEval.value}); | |||
| | if ($unsafeRowBuffer == null) { | |||
| | // failed to allocate the first page | |||
| | throw new OutOfMemoryError("No enough memory for aggregation"); | |||
There was a problem hiding this comment.
opened a JIRA for banning this by a new lint rule: https://issues.apache.org/jira/browse/SPARK-25986
asfgit
pushed a commit
that referenced
this pull request
Nov 14, 2018
## What changes were proposed in this pull request? Add scala and java lint check rules to ban the usage of `throw new xxxErrors` and fix up all exists instance followed by #22989 (comment). See more details in #22969. ## How was this patch tested? Local test with lint-scala and lint-java. Closes #22989 from xuanyuanking/SPARK-25986. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Sean Owen <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…ggregateExec`, too. ## What changes were proposed in this pull request? This is a follow-up pr of apache#20014 which introduced `SparkOutOfMemoryError` to avoid killing the entire executor when an `OutOfMemoryError` is thrown. We should throw `SparkOutOfMemoryError` in `HashAggregateExec`, too. ## How was this patch tested? Existing tests. Closes apache#22969 from ueshin/issues/SPARK-22827/oome. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Add scala and java lint check rules to ban the usage of `throw new xxxErrors` and fix up all exists instance followed by apache#22989 (comment). See more details in apache#22969. ## How was this patch tested? Local test with lint-scala and lint-java. Closes apache#22989 from xuanyuanking/SPARK-25986. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr of #20014 which introduced
SparkOutOfMemoryErrorto avoid killing the entire executor when anOutOfMemoryErroris thrown.We should throw
SparkOutOfMemoryErrorinHashAggregateExec, too.How was this patch tested?
Existing tests.