fix: enable full cookie support for ImpitHttpClient
#2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
There was a problem hiding this comment.
Pull Request Overview
This PR fixes cookie support for ImpitHttpClient and extends the HttpCrawler tests to run with both GotScrapingHttpClient and ImpitHttpClient.
- Updated tests to include both HTTP client implementations.
- Modified ImpitHttpClient to cache both the client and its associated cookie jar based on request options.
- Added a dependency on tough-cookie to support cookie jar functionality.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/core/crawlers/http_crawler.test.ts | Added tests to run HttpCrawler with two different HTTP client options. |
| packages/impit-client/src/index.ts | Updated client cache to include cookieJar, and adjusted client retrieval logic. |
| packages/impit-client/package.json | Updated dependencies to include tough-cookie. |
| packages/http-crawler/src/internals/http-crawler.ts | Propagated cookieJar from session to handle cookies in HTTP requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the
HttpCrawlertests with bothHttpClientimplementations (GotScrapingHttpClient,ImpitHttpClient).Improves cookie store integration for
ImpitHttpClient.