Skip to content

Add tests for changing variables with partial data #12664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

jerelmiller
Copy link
Member

This ports the tests from #11581 which are failing in v3. This appears to have been fixed with the changes we've made for v4 already so this PR is mainly to commit these tests so that we have them for future.

@jerelmiller jerelmiller requested a review from phryneas May 30, 2025 23:25
Copy link

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: 958b016

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented May 30, 2025

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12664

commit: 958b016

Copy link
Contributor

size-limit report 📦

Path Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 42.03 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 37.22 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 32.27 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 26.81 KB (0%)
import { ApolloProvider } from "@apollo/client/react" 5.56 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 963 B (0%)
import { useQuery } from "@apollo/client/react" 11.42 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 6.83 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 6.72 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production) 2.12 KB (0%)
import { useMutation } from "@apollo/client/react" 6.1 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 1.47 KB (0%)
import { useSubscription } from "@apollo/client/react" 6.46 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 1.83 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 8.17 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 3.57 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 7.99 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 3.4 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 7.97 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 3.38 KB (0%)
import { useReadQuery } from "@apollo/client/react" 6.22 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 1.61 KB (0%)
import { useFragment } from "@apollo/client/react" 6.29 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 1.68 KB (0%)

@github-actions github-actions bot added the auto-cleanup 🤖 label Jun 2, 2025
@jerelmiller jerelmiller merged commit 9bb9947 into release-4.0 Jun 2, 2025
44 of 45 checks passed
@jerelmiller jerelmiller deleted the jerel/changing-vars branch June 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants