chore: update documentation to include install commands for typescript #7691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@torressam333: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d5bfc4f:
|
trevor-scheer
suggested changes
Aug 18, 2023
torressam333
force-pushed
the
torressamm333/typescript-install-packages
branch
from
ecea6a4 to
d5bfc4f
Compare
|
@trevor-scheer great suggestions! Changes have been made, commit has been squashed and is now updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In the process of migrating from apollo-server-express to just using apollo-server v4 I was following the migration guide here: https://www.apollographql.com/docs/apollo-server/migration/#migrate-from-apollo-server-express and when I installed the
corspackage and imported it into myindex.tsfile I got the error shown in the readme.md file below. I believe it is important to include the corresponding Typescript commands to use for other users who will migrate to v4.Thanks!