Skip to content

feat: add events endpoint calls #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 2, 2025
Merged

feat: add events endpoint calls #913

merged 10 commits into from
Mar 2, 2025

Conversation

KazuCocoa
Copy link
Member

List of changes

Supports https://github.com/appium/python-client/blob/22189335caccd89daffc3519bba8c90360be5fd1/appium/webdriver/extensions/log_event.py#L24 in dotnet client as well.

I noticed that the .net client hasn't implemented the endpoint call.

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Console.WriteLine(JsonSerializer.Serialize(_driver.GetEvents()));
// {"commands":[],"xcodeDetailsRetrieved":[1739954518764],"appConfigured":[1739954518766],"resetStarted":[1739954518768],"resetComplete":[1739954518769],"logCaptureStarted":[1739954522220],"simStarted":[1739954523379],"wdaStartAttempted":[1739954523539],"wdaSessionAttempted":[1739954523541],"wdaSessionStarted":[1739954523560],"wdaStarted":[1739954523560]}

Console.WriteLine(JsonSerializer.Serialize(_driver.GetEvents(type: ["commands"])));
// {"commands":[{"cmd":"getLogEvents","startTime":1739954523614,"endTime":1739954523614}]}

driver.LogEvent("appium", "neko");
Console.WriteLine(JsonSerializer.Serialize(_driver.GetEvents()));
// {"commands":[{"cmd":"getLogEvents","startTime":1739954523614,"endTime":1739954523614},{"cmd":"getLogEvents","startTime":1739954523645,"endTime":1739954523645},{"cmd":"logCustomEvent","startTime":1739954523656,"endTime":1739954523656},{"cmd":"logCustomEvent","startTime":1739954523657,"endTime":1739954523657},{"cmd":"logCustomEvent","startTime":1739954523658,"endTime":1739954523658}],"xcodeDetailsRetrieved":[1739954518764],"appConfigured":[1739954518766],"resetStarted":[1739954518768],"resetComplete":[1739954518769],"logCaptureStarted":[1739954522220],"simStarted":[1739954523379],"wdaStartAttempted":[1739954523539],"wdaSessionAttempted":[1739954523541],"wdaSessionStarted":[1739954523560],"wdaStarted":[1739954523560],"appium:neko":[1739954523656,1739954523657,1739954523658]}

@KazuCocoa KazuCocoa requested a review from Dor-bl February 20, 2025 09:15
Copy link
Collaborator

@Dor-bl Dor-bl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests were added?

@KazuCocoa KazuCocoa marked this pull request as draft February 22, 2025 07:00
@KazuCocoa KazuCocoa marked this pull request as ready for review March 2, 2025 17:48
@KazuCocoa KazuCocoa requested a review from Dor-bl March 2, 2025 19:51
@KazuCocoa KazuCocoa merged commit aaec938 into main Mar 2, 2025
3 checks passed
@KazuCocoa KazuCocoa deleted the events branch March 2, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants