Ensure offline support works in linux #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
fix-offline-linux
branch
from
292bcf6 to
3e5fc9b
Compare
This was referenced Mar 14, 2023
lohanidamodar
approved these changes
Mar 15, 2023
stnguyen90
force-pushed
the
fix-offline-linux
branch
from
3e5fc9b to
bea62ad
Compare
@lohanidamodar the only error was:
which I have now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To ensure sqflite works on Windows and Linux, sqflite_common_ffi is required.
Test Plan
Manual
Related PRs and Issues
Previous PRs:
Have you read the Contributing Guidelines on issues?
Yes