chore: update test to version 0.27.1 #106
Conversation
|
@krol3 What do you mean "update test"? |
|
Looks like this PR updates Trivy version. It also updates tests though. |
Using bats, we have unit test for the entrypoint.sh. I updated with the option "secret" for example. |
Hmm, so doesn't this PR update Trivy version? This change affects only tests, right? |
@knqyf263 I update the image version here https://github.com/krol3/trivy-action/blob/trivy-0.27/Dockerfile#L1 |
|
If we update the Trivy version, I'm feeling like the test is not main concern in this PR. Am I correct? I saw the PR title and commit message, then I thought this PR just updated tests. But it looks like it updates the Trivy version as well. That's why I'm confused as I'm not so familiar with trivy-action.
You mean this action will use v0.27.0, right? |
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| @test "trivy fs with securityChecks option" { | |||
| # trivy fs -f json --security-checks=vuln,config -o fs.test . | |||
| ./entrypoint.sh '-a fs' '-j .' '-b json' '-s vuln,config' '-h fs-scheck.test' | |||
| ./entrypoint.sh '-a fs' '-j .' '-b json' '-s vuln,config,secret' '-h fs-scheck.test' | |||
There was a problem hiding this comment.
- Where is
fs-scheck.test? Did you forgot to check it in? - Can we update the repo with a dummy secret and accordingly update the golden file to make an assertion?
There was a problem hiding this comment.
yeah! @simar7 I forgot to add the data/fs-scheck.test
There was a problem hiding this comment.
Related (2), I using the trivy repo with the secret option.
|
hi @krol3 - any update on this? Some users are trying to use secret scanning with Trivy Action and won't be able to until we update it with merging this PR. |
krol3
force-pushed
the
trivy-0.27
branch
2 times, most recently
from
c93ade7 to
e855258
Compare
krol3
changed the title
|
@simar7 the PR was updated with all your review's point |
|
If there is anything I can help with on this PR, please let me know. I'm anxiously waiting for secret scanning and I don't want to build a custom action just for my use. :-) |
No description provided.