feat: terraform parser option to set current working directory #8909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform `path.cwd` intends to be the directory `terraform` was executed from. This value should be controllable by the caller. Especially when using in memory file systems, the actual filesystem is irrelevant.
nikpivkin
reviewed
May 24, 2025
| @@ -52,6 +52,9 @@ type Parser struct { | |||
| fsMap map[string]fs.FS | |||
| configsFS fs.FS | |||
| skipPaths []string | |||
| // cwd is optional, if provided it will be used instead of 'os.Getwd' | |||
| // for populating 'path.cwd' in terraform | |||
| cwd *string | |||
There was a problem hiding this comment.
Why can't an empty string mean no cwd?
There was a problem hiding this comment.
I can do that 👍, just wanted it to be an explicit opt in.
simar7
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Terraform
path.cwdintends to be the directoryterraformwas executed from. This value should be controllable by the caller. Especially when using in memory file systems, the actual filesystem is irrelevant.In the my use case, ideally I would not leak any information of the actual file system of the host executing the terraform scanning.
Checklist