Cannot convert object to primitive value

[paales]

Describe the bug
Cannot convert object to primitive value while using an open API endpoint.

To Reproduce
Steps to reproduce the behavior:

1. https://codesandbox.io/s/elastic-black-hhokf?file=/.meshrc.yaml
2. Run the following query

query Search {
  searchCollection(collectionName: "collection", searchParameters: {q: "bla"}) {
    tookMs
  }
}

3. You get the following error

{
  "errors": [
    {
      "message": "Cannot convert object to primitive value",

Expected behavior

• For the request to go through, or
• GraphQL Mesh not to start because there is an error in the schema.

[Shiroh1ge]

hey @paales , I'm currently facing the same issue, I'm guessing Mesh is trying to cast the query params to a string, but is receiving an object, can you give me an idea of how your workaround looks like?

[paales]

I accidentally closed the issue, we haven't solved it yet

[Shiroh1ge]

Some update on my end, it seems the query does a simple params.set(paramName, val) on whatever gets passed as a query, since the val when setting params has to be a string, if you give it an object it gives you this error, is it possible to override this behavior?

[Shiroh1ge]

update 2: I decided to just comment out the code and use qs.stringify on the whole query object. It seems to work properly now with nested objects, would be best if we can get this fixed somehow as I'd like to avoid meddling with the source code.

The end result in the urlObject is:

{
...
  search: '?%24sort%5Bname%5D=test&organization_id=test',
  searchParams: URLSearchParams { '$sort[name]' => 'test', 'organization_id' => 'test' },
}

which is equivalent to passing a query param, looking like this:

?organization_id=test&$sort[name]=test

or from a GraphQL query

query getPreferences(organizationId: "test", sort: {name: "test"} ) {
  data {
    id
  }
}

@santino @ardatan maybe one of you guys can take a quick look and confirm that the Mesh doesn't properly transform nested objects to query params, I would love to create a PR if this would fix the issue! thanks

[Shiroh1ge]

update 3: Seems passing a dynamic input doesn't produce this error, but in the end result the object just gets converted to a string and becomes [object Objet] instead of actual query params.

query test($organizationId: String!, $sort: SortInput){
  getPreferences(organizationId: $organizationId, sort: $sort ) {
    data {
      id
    }
  }
}

payload:

{
"organizationId": "test",
"sort": {
  "createdAt": 1
   }
}

becomes:

http://localhost:3000/preferences?organization_id=test&%24sort=%5Bobject+Object%5D',

In the end I think the problem is the same

[ardatan]

In order to support nested parameters, we have to replace URLSearchParams with an object, serialize with qs.stringify add it to the url

[Shiroh1ge]

@ardatan Thanks for the response! Yes, I used qs.stringify and this solved the problem for me. Would that be something you want to implement? If so I could help create a PR if you would give me some instructions if there are any edge cases that need to be handled.

If not, is there a workaround that I can do in a way that doesn't force me to fork the repo and edit the source code manually?

[nemonemi]

I have just encountered this myself.
I have 2 very simple API services that I'm transforming in the graphql-mesh.

sources:
  - name: Certificates
    handler:
      graphql:
        endpoint: http://localhost:4100/graphql
    transforms:
      - typeMerging:
          queryFields:
            - queryFieldName: certificates
              keyField: id
              keyArg: ids
  - name: Companies
    handler:
      graphql:
        endpoint: http://localhost:4200/graphql
    transforms:
      - rename:
          renames:
            - from:
                type: CertificateWithCompanies
              to:
                type: Certificate
            - from:
                type: Query
                field: certificateWithCompanies
              to:
                type: Query
                field: certificate
      - typeMerging:
          queryFields:
            - queryFieldName: company
              keyField: id
            - queryFieldName: certificate
              keyField: id

serve:
  port: 5000
  playground: true
  browser: false

Has this already been resolved, and if so, how?

Update 1

I have deduced that this occurs when both the Company and the Certificate types have the same-named property name.

Once I renamed one of those types' properties from name to title, it started working.

This, however, I would say is not really a solution, because there will be cases where it will not be possible to change it or not desirable.

[JasonKong-Quantium]

I've encountered the same error while trying to put Typesense (https://typesense.org/) behind GraphQL Mesh

The typesense API spec is from https://github.com/typesense/typesense-api-spec/blob/master/openapi.yml

I'm going to try to put together a PR, which may take a few days as NodeJS isn't my forte