Skip to content

Update AnalogReadSerial.ino #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Update AnalogReadSerial.ino #23

merged 1 commit into from
Nov 25, 2020

Conversation

kengdahl
Copy link
Member

Fixed faulty link

Fixed faulty link
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please, please, please also set up redirects for these URLs. I'm sure thousands of links to the previous URL all over the Internet were broken by the change that caused this to be necessary.

@ubidefeo
Copy link
Contributor

@per1234 what are you referring to?
@kengdahl asked me to merge the PR but I don't fully understand which URL redirects you intend here

@per1234
Copy link
Contributor

per1234 commented Nov 24, 2020

@ubidefeo there was a change to the structure of the documentation content on arduino.cc that changed URLs. Some of the old URLs were not redirected, which was the case with http://www.arduino.cc/en/Tutorial/AnalogReadSerial, which was likely the motivation for this PR.

I see that now http://www.arduino.cc/en/Tutorial/AnalogReadSerial does redirect as it should to the new URL https://www.arduino.cc/en/Tutorial/BuiltInExamples/AnalogReadSerial (thanks!), but I think it's still a good idea to update this URL to point to the new location of the content to avoid relying on the redirect. The same issue occurs in every single example in this repository.

@ubidefeo
Copy link
Contributor

thanks @per1234 , that detail was lost on me.
please @kengdahl , if you can set a task to make sure all URLs in this repo are aligned adding the /BuiltinExamples portion of the path.
In the meantime I'll merge this one

@ubidefeo ubidefeo merged commit 8e69527 into arduino:main Nov 25, 2020
@kengdahl
Copy link
Member Author

kengdahl commented Nov 26, 2020

@ubidefeo I'll do that.

@kengdahl kengdahl deleted the patch-1 branch November 26, 2020 12:15
@per1234
Copy link
Contributor

per1234 commented Mar 26, 2021

I'll do that.

Forget about it. I went ahead and did it. Please review: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants