Skip to content

Add SchneiderModbusTCP library by mmercalde #6475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2025

Conversation

mmercalde
Copy link
Contributor

This pull request adds the SchneiderModbusTCP library to the Arduino Library Manager.

Features:

  • Read/write 16- and 32-bit Modbus holding registers
  • Read/write coils (FC 01 and 05)
  • Schneider-specific byte and word ordering support
  • Tested with Conext XW, MPPT, AGS, and Battery Monitor devices
  • Includes two usage examples and full documentation
  • MIT Licensed

GitHub: https://github.com/mmercalde/SchneiderModbusTCP

Copy link
Contributor

Hi @mmercalde.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: other Something other than a library list request label Jun 21, 2025
@github-actions github-actions bot requested a review from per1234 June 21, 2025 23:03
Copy link
Contributor

Hi @mmercalde.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

Hi @mmercalde.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@mmercalde
Copy link
Contributor Author

This is a valid Arduino Library Manager submission. JSON filename and formatting meet registry guidelines. Please review for inclusion.

@per1234 per1234 self-assigned this Jun 22, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mmercalde. Thanks for your interest in contributing to the Arduino Library Manager.

This is a valid Arduino Library Manager submission. JSON filename and formatting meet registry guidelines.

It is not valid and it does not meet the guidelines. Please carefully read and follow the instructions for submitting a library to the Arduino Library Registry:

https://github.com/arduino/library-registry#adding-a-library-to-library-manager


If you have any questions or problems while following those instructions, just comment here to let me know and I'll provide further assistance.

@per1234 per1234 added status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list and removed topic: other Something other than a library list request labels Jun 22, 2025
@mmercalde
Copy link
Contributor Author

Hi @per1234 — I've fixed the url in library.properties and re-created the v1.0.0 release with the corrected metadata. Please re-review when possible. Thank you!

@per1234
Copy link
Contributor

per1234 commented Jun 22, 2025

@mmercalde you must follow the instructions:

https://github.com/arduino/library-registry#adding-a-library-to-library-manager

It is very simple. You only need to add the URL of your library repository to a text file. I don't know where you got the idea you were supposed to add a JSON file to this repository. That is not how it works. You would know this if you bothered to read the instructions as I told you to do. Please read them.

Copy link
Contributor

Hi @mmercalde.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: other Something other than a library list request and removed status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list labels Jun 22, 2025
@github-actions github-actions bot requested a review from per1234 June 22, 2025 01:25
@per1234
Copy link
Contributor

per1234 commented Jun 22, 2025

@mmercalde you are getting closer. Now you only need to delete the libraries/SchneiderModbusTCP.json file you added.

@github-actions github-actions bot removed the request for review from per1234 June 22, 2025 02:16
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: other Something other than a library list request labels Jun 22, 2025
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/mmercalde/SchneiderModbusTCP:

Linting library in SchneiderModbusTCP
WARNING: Sketch(es) found outside examples and extras folders:                                    
           SchneiderModbusTCP                                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit 5b8eeae into arduino:main Jun 22, 2025
11 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/mmercalde/SchneiderModbusTCP/

github-actions bot pushed a commit that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants