-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add SchneiderModbusTCP library by mmercalde #6475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mmercalde. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Hi @mmercalde. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Hi @mmercalde. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
This is a valid Arduino Library Manager submission. JSON filename and formatting meet registry guidelines. Please review for inclusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mmercalde. Thanks for your interest in contributing to the Arduino Library Manager.
This is a valid Arduino Library Manager submission. JSON filename and formatting meet registry guidelines.
It is not valid and it does not meet the guidelines. Please carefully read and follow the instructions for submitting a library to the Arduino Library Registry:
https://github.com/arduino/library-registry#adding-a-library-to-library-manager
If you have any questions or problems while following those instructions, just comment here to let me know and I'll provide further assistance.
Hi @per1234 — I've fixed the |
@mmercalde you must follow the instructions: https://github.com/arduino/library-registry#adding-a-library-to-library-manager It is very simple. You only need to add the URL of your library repository to a text file. I don't know where you got the idea you were supposed to add a JSON file to this repository. That is not how it works. You would know this if you bothered to read the instructions as I told you to do. Please read them. |
Hi @mmercalde. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
@mmercalde you are getting closer. Now you only need to delete the |
@per1234 JSON file has been deleted.
Arduino Lint has suggestions for possible improvements to https://github.com/mmercalde/SchneiderModbusTCP:
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
This pull request adds the SchneiderModbusTCP library to the Arduino Library Manager.
Features:
GitHub: https://github.com/mmercalde/SchneiderModbusTCP