AT new CLIENTCONNECT commands with parameter for timeout #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing connect commands have a strict check for number of parameters so they can't be adopted for additional parameter without loosing compatibility of the library with older firmware.
There is no need to have extra command for connect with IP address. The
connectwith hostname useshostByNamewhich first attempts to convert the string to IP address. So my new AT commands with parameter timeout are simple CLIENTCONNECT and SSLCLIENTCONNECT. I think these commands should have timeout as optional parameter even the library will not use them without that parameter. (without timeout set, the library will use the commands which exists in older firmware )There is no way to retrieve the default timeout of the esp32 WFiClient so I copied the current define for the default to use esp32
connectwith parameter timeout only. This ensures that if CLIENTCONNECT is called without the timeout parameter, it will use the default value, not the last used value.