Skip to content

feat: add extra volume and volumeMounts spec to Dex #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

miinsun
Copy link

@miinsun miinsun commented Mar 17, 2025

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:
This PR includes the following fields in the DexSpec type:

  • .spec.sso.dex.volumes
  • .spec.sso.dex.volumeMounts

This ensures that Dex deployment can properly handle volumes and volume mounts.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #1597

How to test changes / Special notes to the reviewer:

@svghadi
Copy link
Collaborator

svghadi commented Apr 7, 2025

Hi @miinsun , thanks for the PR. Can you run make generate manifests bundle to fix the codegen CI check?

@miinsun
Copy link
Author

miinsun commented Apr 9, 2025

Hi @svghadi , sure! I ran make generate manifests bundle and pushed the updated files.

Just a quick note — on macOS, the sed -i command in the Makefile was causing an error due to the sed syntax. I was able to fix it by changing:

❌ sed -i 's/control-plane: argocd-operator/control-plane: ...   

✅ sed -i '' 's/control-plane: argocd-operator/control-plane: ... 

@miinsun miinsun force-pushed the f/dex-extra-volume-mounts branch 4 times, most recently from 143e082 to e3b70c9 Compare May 10, 2025 04:03
@miinsun
Copy link
Author

miinsun commented May 10, 2025

Hi @svghadi,

I’m encountering some SSO configuration errors in my E2E runs:

2025-05-10T04:27:38Z ERROR controller_argocd  
  Failed to update existing SSO Configuration for ArgoCD “argocd”  
  in namespace kuttl-test-guiding-lacewing  
  {"error":"illegal SSO configuration: cannot supply dex configuration when requested SSO provider is keycloak"}

2025-05-10T04:32:49Z ERROR controller_argocd  
  Failed to update existing SSO Configuration for ArgoCD “argocd”  
  in namespace test-1-042-restricted-pss-compliant  
  {"error":"illegal SSO configuration: must supply valid dex configuration when requested SSO provider is dex"}

I originally assumed that simply adding the following fields would be sufficient:

  • spec.sso.dex.volumes
  • spec.sso.dex.volumeMounts

However, the E2E failures suggest there’s more to it.

Do we need to update the ArgoCD SSOConfig CRD (or controller logic) to properly handle these new Dex volumes and volumeMounts fields? Any guidance or a reference fixture/example would be greatly appreciated!

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting volume mounts for dex container
2 participants