-
Notifications
You must be signed in to change notification settings - Fork 920
feat: add extra volume and volumeMounts spec to Dex #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: miinsun <[email protected]>
Signed-off-by: miinsun <[email protected]>
Signed-off-by: miinsun <[email protected]>
Signed-off-by: miinsun <[email protected]>
Signed-off-by: miinsun <[email protected]>
Signed-off-by: miinsun <[email protected]>
Hi @miinsun , thanks for the PR. Can you run |
Signed-off-by: miinsun <[email protected]>
Hi @svghadi , sure! I ran make generate manifests bundle and pushed the updated files. Just a quick note — on macOS, the sed -i command in the Makefile was causing an error due to the sed syntax. I was able to fix it by changing:
|
143e082
to
e3b70c9
Compare
Hi @svghadi, I’m encountering some SSO configuration errors in my E2E runs:
I originally assumed that simply adding the following fields would be sufficient:
However, the E2E failures suggest there’s more to it. Do we need to update the ArgoCD SSOConfig CRD (or controller logic) to properly handle these new Dex volumes and volumeMounts fields? Any guidance or a reference fixture/example would be greatly appreciated! Thanks 😊 |
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR includes the following fields in the DexSpec type:
This ensures that Dex deployment can properly handle volumes and volume mounts.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1597
How to test changes / Special notes to the reviewer: